From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2163C433F5 for ; Tue, 19 Oct 2021 13:14:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFAE16103B for ; Tue, 19 Oct 2021 13:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFAE16103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gksoYhjB9xDvAqqvHHywlJulo/wGTmjpglbEBBjrtas=; b=mUcNld+fZYmAwf iGrn9TLEtGQfvzO7hQSK0imTJ5S+tzfPzFhO9k5dFf7kiTFMDF6cI9QcSHEaL7pgmZ2aud2qtoRtz WgfQYQrceUoMmwvkr8nPzplxE1+iYvhIzYRgNTESojXyejwM0Ajy4Qd8tfbI3/EhVhSqUE1DGwHW6 FI5orrKogTIHBxdIIdbFKcHJjHDxBWojAw59BUaLBmkeLWYfpZKDahObbKQJRFSbpLM2lrRnG6YTo ze0PQQDj8eLaJYtuUnxd7Q3QCMfztMcEyNCSGDm37K+Th0YOKIJ1/pUEtofJL5vgpSQ1v9wDVbbK8 ZAgr6mNw9OL6iBniMjvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcov8-001N22-Kc; Tue, 19 Oct 2021 13:12:46 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcov5-001N1H-HQ for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 13:12:44 +0000 Received: by mail-pg1-x52d.google.com with SMTP id h193so3910838pgc.1 for ; Tue, 19 Oct 2021 06:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Rg3Kgw5vrNE8ltWjJ/Ne3mXQemq6Bfc8CUmnwiMggRw=; b=D6BSuqx0TWFkCEOBKE917Xo1JDqEEx9wA3q0Az+amnAPUVfuxM0vyEWVOsllwg3H2K E6jvrPgzpFAdtBgQRzYpqgx24raI+8XbiKnFe0Z0VEmAdof1ew4kVWOFY4jwDSm++Wb/ Rc376WqNMDCvYmujsCRH4BMi2frzu6RATFIXo0kB0kbjTz/oWNcFKhxU3UkjoL0HDEXG bjjUfifwQSlcEoi/dcodmv51hWSpXQoS0mxQ62qAzSwwByzAlPv+DGVtVw4uw4w0Q1Do n7FxnE38TjXXUtQGp4VR3honnC3jiIqWHUoCEni9YlLDdVv+v6xSYy9i7mtiktFowRGs hc9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rg3Kgw5vrNE8ltWjJ/Ne3mXQemq6Bfc8CUmnwiMggRw=; b=PPj9hLuIQl+j09yx5MPIhvqtgxAHliF8flg93MxI+uADEr6XkeQfmWx4X9x/Au0zZg XjUdfyHV/etUtuvrV2bwZjuLR+/g9ONMSq0tZYyar5j3JXqvuU3Lx5qGJwsLhfZOeIhY IxXehLlL48NPEcoBP8E3nykWOaVbv3p8Gog4on4Z3AziM68DjajZP8cRCUVmNNzgtVJf iBn3z4EOxnTz568pxEKDiWQsZ5WgcOehPG6r8mCTlwK+GPIVgC3hlTPmrR0wK7cUhoPv 0HYG+RxO9CR/ncCZaLqP5VqoH95w4c4ER8fPp9Vd/934p0Qea9zB75HpUZMJie0xZTZ/ 6VUg== X-Gm-Message-State: AOAM533QlS8fTuLExF8DhGS93Cs7CSVc+3YTw5A7/g34xMAyj+EUJI3V Aw8r+466v+WhEoWZJSB1qO2KcQ== X-Google-Smtp-Source: ABdhPJwcJIzKy4K/gAyjAYe2/KbWJInKZvxsFfmnIxMXkTdqq1VkXvuq6/T3HIw/Bokls8TqSs8O4Q== X-Received: by 2002:aa7:9ede:0:b0:44d:13c7:14a7 with SMTP id r30-20020aa79ede000000b0044d13c714a7mr35099523pfq.18.1634649162095; Tue, 19 Oct 2021 06:12:42 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([148.163.172.147]) by smtp.gmail.com with ESMTPSA id 1sm5262347pfl.133.2021.10.19.06.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 06:12:41 -0700 (PDT) Date: Tue, 19 Oct 2021 21:12:34 +0800 From: Leo Yan To: German Gomez Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, James Clark Subject: Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback Message-ID: <20211019131234.GA221392@leoy-ThinkPad-X240s> References: <1c6a3a73-27dc-6673-7fe7-34bc7fcb0a68@arm.com> <20211004122724.GC174271@leoy-ThinkPad-X240s> <6b092f13-832f-5d1d-a504-aea96c81bf17@arm.com> <20211006095124.GC14400@leoy-ThinkPad-X240s> <377b54ef-b9c0-9cfc-ef0c-0187d7c493cc@arm.com> <20211013003916.GA130842@leoy-ThinkPad-X240s> <20211013075125.GA6701@willie-the-truck> <35209d5c-6387-5248-ab61-a1e1cb0553de@arm.com> <20211017061305.GA130233@leoy-ThinkPad-X240s> <5e59784e-3f09-cfbc-1692-f3a5d85b0995@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5e59784e-3f09-cfbc-1692-f3a5d85b0995@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_061243_631050_ED32E501 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi German, On Tue, Oct 19, 2021 at 10:23:01AM +0100, German Gomez wrote: > Hi Leo, > > Yeah I agree the redundant AUX events are adding unnecessary bloat to > the perf.data file... We actually cam across this when doing one of the > test cases. Sorry for not reporting it! No worries. > Could we patch the driver in a separate patch set? Or do you think this > is critical for the purposes of this one? Yeah, we can take low priority for the redundant AUX events issue. Please take a look for the issue mentioned in another email for recording trace data with wrong size. I think the issue for wrong snapshot trace size should have a fixing in Arm SPE driver, and the fixing need to be verified with the perf patches. After that I am fine for merging the perf patches (and you could upstream kernel driver patches separately). How about you think? Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel