Re: [PATCH v3 0/2] PCI MCFG consolidation and APEI resource filterin

Bjorn Helgaas
2021-10-19T15:14:26Z

On Tue, Oct 19, 2021 at 12:49:16PM +0800, Xuesong Chen wrote:
> Hello All,
>
> The idea of this patch set is very strainforward, it's somehow a refactor
> of the original codes to share some ones that they should do. Based on that,
> we can resolve the MCFG address access issue in APEI module on x86 in a
> command way instead of the current arch-dependent one, while this issue also
> does happen on ARM64 platform.
>
> The logic of the series is very clear(IMO it's even time-wasting to explain that):

If you want people to look at and care about your changes, it is never
a waste of time to explain them.

> Patch #1: Escalating the 'pci_mmcfg_list' and 'pci_mmcfg_region' to the
> pci.[c,h] which will shared by all the arches. A common sense, in some degree.
>
> Patch #2: Since the 'pci_mmcfg_list' now can be shared across all arches,
> the arch-specific fix method can be replaced by the new solution naturally.
>
> Now the v3 patch has been finalized, can we move forward to the next step? -
> either give the concerns/objections or pick it up.

It's helpful to your reviewers if you include a note about changes
between v2 and v3, as you did in your v2 0/2 cover letter.

It's also helpful if you thread the series with patches 1 and 2 as
responses to the cover letter. That makes it easy to download the
patches using b4. Here's a little more background:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v5.14#n320

> Xuesong Chen (2):
> PCI: MCFG: Consolidate the separate PCI MCFG table entry list
> ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method
>
> arch/x86/include/asm/pci_x86.h | 17 +---------------
> arch/x86/pci/mmconfig-shared.c | 30 ----------------------------
> drivers/acpi/apei/apei-base.c | 45 ++++++++++++++++++++++++++++--------------
> drivers/acpi/pci_mcfg.c | 34 ++++++++++++-------------------
> drivers/pci/pci.c | 2 ++
> include/linux/pci.h | 17 ++++++++++++++++
> 6 files changed, 63 insertions(+), 82 deletions(-)
>
> --
> 1.8.3.1
>