From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AF5C433F5 for ; Tue, 19 Oct 2021 19:47:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A917610CC for ; Tue, 19 Oct 2021 19:47:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A917610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=n0/UyH+/32YwevT5aSfcpYvAbk0AVLE/aOlNCVUlIGI=; b=iPsnK62PqEebGh vD59DrwxPYJgWI52UO0SZUQ+Y1+3K0meH3Fs515yTQpvtnGyVYWqunA2DCwJD0XFLgqknD599J4M8 2gKmpxWm9Y7TZK57WJxnrG5yZ0FeLK/O+QMZh0w1s1UyafqywTIwzBsTZRlTUT65Nokg3+2c33CQu XNRB72urXX6hdd6IIak+MdrKl/QpsBFUovye0SxGiw8ngNykx15ERitCbbrd3GTjv6oqbDvZmwXUO pGIrb8Pv0xDXjqjBw6rjEYsKhyGLRiN+kuMaij5SpgEvhJjrYREk7lNTV8OUstXv7BRIGFOdxVMt3 ttynkvKqb2zsWl/hEuwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcv3X-002XRI-HE; Tue, 19 Oct 2021 19:45:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcv3T-002XQy-U4 for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 19:45:49 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F58960F02; Tue, 19 Oct 2021 19:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634672747; bh=Kt0AlgCnA2CCkwUWkmwrgijsbjnxUNTjrXExJc4067Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ZQ2ekrgapNYGiJEhyAne+AuIDwhvbAlMAdhgFNLyAcyHb4zqKBZ9TUWsGniOYrPMB tqpeouJPddT5+T8S1zm2cOnM1snf4/Ij9wY/Y1QqZUJKuljJu4qNJlum5HNtml0Oiq r5Z8hch+Ts8uGkRWL6hGdyys/9NtHtk9H9oioQWqOKPVeReHIMCVSKUv/IAzUO5xbC DsJiN6+H0fLjgYEsVVEUFiDdoOJeLU0x4DDzm5yqDrXo1tLQl4cKYFrl+lkXJIaEsf 6lfLoQsD4NCvqZsS2Clyt0UzN9A3TTigGOjVQ0cA2NdthrmMOzubrqPAc0NWQomrAI gyP0pRRBc5tFQ== Date: Tue, 19 Oct 2021 14:45:45 -0500 From: Bjorn Helgaas To: =?iso-8859-1?Q?Ma=EDra?= Canal Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci-imx6: replacing legacy gpio interface for gpiod Message-ID: <20211019194545.GA2393463@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_124548_072216_8E3A086D X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [fixed "linux-pci@vger.kernel.org" in cc] On Tue, Oct 19, 2021 at 12:26:53PM -0300, Ma=EDra Canal wrote: > Removing all dependencies of linux/gpio.h and linux/of_gpio.h and replaci= ng > it with linux/gpio/consumer.h Run "git log --oneline drivers/pci/controller/dwc/pci-imx6.c" and make your subject line match -- capitalization, sentence structure, etc. Write commit log in imperative mood, i.e., "Remove" instead of "Removing": https://chris.beams.io/posts/git-commit/ The commit log mentions the trivial part but omits the important part (converting from gpio to gpiod model). > Signed-off-by: Ma=EDra Canal > --- > drivers/pci/controller/dwc/pci-imx6.c | 31 ++++++++++----------------- > 1 file changed, 11 insertions(+), 20 deletions(-) > = > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controll= er/dwc/pci-imx6.c > index 80fc98acf097..e5ee54e37d05 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -11,13 +11,12 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > #include > #include > -#include > #include > #include > #include > @@ -63,7 +62,7 @@ struct imx6_pcie_drvdata { > = > struct imx6_pcie { > struct dw_pcie *pci; > - int reset_gpio; > + struct gpio_desc *reset_gpio; > bool gpio_active_high; > struct clk *pcie_bus; > struct clk *pcie_phy; > @@ -526,11 +525,11 @@ static void imx6_pcie_deassert_core_reset(struct im= x6_pcie *imx6_pcie) > usleep_range(200, 500); > = > /* Some boards don't have PCIe reset GPIO. */ > - if (gpio_is_valid(imx6_pcie->reset_gpio)) { > - gpio_set_value_cansleep(imx6_pcie->reset_gpio, > + if (imx6_pcie->reset_gpio) { > + gpiod_set_value_cansleep(imx6_pcie->reset_gpio, > imx6_pcie->gpio_active_high); > msleep(100); > - gpio_set_value_cansleep(imx6_pcie->reset_gpio, > + gpiod_set_value_cansleep(imx6_pcie->reset_gpio, > !imx6_pcie->gpio_active_high); > } > = > @@ -1025,22 +1024,14 @@ static int imx6_pcie_probe(struct platform_device= *pdev) > return PTR_ERR(pci->dbi_base); > = > /* Fetch GPIOs */ > - imx6_pcie->reset_gpio =3D of_get_named_gpio(node, "reset-gpio", 0); > imx6_pcie->gpio_active_high =3D of_property_read_bool(node, > "reset-gpio-active-high"); > - if (gpio_is_valid(imx6_pcie->reset_gpio)) { > - ret =3D devm_gpio_request_one(dev, imx6_pcie->reset_gpio, > - imx6_pcie->gpio_active_high ? > - GPIOF_OUT_INIT_HIGH : > - GPIOF_OUT_INIT_LOW, > - "PCIe reset"); > - if (ret) { > - dev_err(dev, "unable to get reset gpio\n"); > - return ret; > - } > - } else if (imx6_pcie->reset_gpio =3D=3D -EPROBE_DEFER) { > - return imx6_pcie->reset_gpio; > - } > + imx6_pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", > + imx6_pcie->gpio_active_high ? GPIOD_OUT_HIGH : > + GPIOD_OUT_LOW); > + if (IS_ERR(imx6_pcie->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpio), > + "unable to get reset gpio\n"); > = > /* Fetch clocks */ > imx6_pcie->pcie_phy =3D devm_clk_get(dev, "pcie_phy"); > -- = > 2.31.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel