From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890C0C433EF for ; Mon, 25 Oct 2021 17:04:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C77C60F22 for ; Mon, 25 Oct 2021 17:04:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C77C60F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JaZ0nQI+4MzwxqFCjlkpSGvPS2wvcCgfVJ676/YEpag=; b=h+pxEV4c9XEWDr uyvW0lgyw7MGsUSETxE0HqfEiXS1KhcZCLSxJJa4n1M+jYXwUA3JI966E6LQhkZ8018KyoESRU/Qi xoe+DNiRvxTJsfeXVtaCQAJW4+96Luu++L50D4cpHmro5swirk7fmMKk7Dq0KrQDi7UNO52cIkfGj GlBKENKfwqyltUPT8sc7XE+7cJ+JdTXTJNuwrRerrZyht93MdS1MpJ9g4fF3AhSZlP8POWBo15XY6 H3EwRUDJEsFTf5a4vaX3n+l5wsrycNBgCj86GNztLrFT7vGjKTjr5w8MoEomb91/4cGwYhsvGX6Hz vjBJWbnnhKnbmo0FXWrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf3NH-00H9ue-QM; Mon, 25 Oct 2021 17:03:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf3LU-00H8p1-LJ for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 17:01:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69D2460FE8; Mon, 25 Oct 2021 17:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635181272; bh=q7Q+qaHQXxKtTdLOzrU+axS9O1AHz6CsjUf1HE8HpYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OtvfMiYhNZYFwI+UsgLzt1HwBX82wcu13R90/166cWK0IjhYwgeN9onKhJVTUZI8x JTtFKRvXk28hSof7JbDZ2A32Y5KvgZwkFPpcYDmeMQ2QSw7sFZnYTOxdS4zvICD3v8 g2RpkY62YSVF/sKRJJf96/8GToYFLpzgsmj7SskIjIWjcRrZQZNVBTvZ0AO54BnwAt cHleK9ANorSeobfqsMqjgU3HOS7CKIxWf8v+YNQowk6rRJF2QxLWcaJgeUM85WtkPA W9gGQctIbQ+VRQ8MhGnjKdRhMXcXHAbwYhZGk/J8VMhp9UCbQ1xixYTttJrtto9HjF dc9qjRnWwuWFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , "David S . Miller" , Sasha Levin , sgoutham@marvell.com, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 2/7] cavium: Return negative value when pci_alloc_irq_vectors() fails Date: Mon, 25 Oct 2021 13:00:57 -0400 Message-Id: <20211025170103.1394651-2-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211025170103.1394651-1-sashal@kernel.org> References: <20211025170103.1394651-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_100112_768376_44553259 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zheyu Ma [ Upstream commit b2cddb44bddc1a9c5949a978bb454bba863264db ] During the process of driver probing, the probe function should return < 0 for failure, otherwise, the kernel will treat value > 0 as success. Signed-off-by: Zheyu Ma Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c index 90497a27df18..7c0a67f1f43f 100644 --- a/drivers/net/ethernet/cavium/thunder/nic_main.c +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c @@ -1175,7 +1175,7 @@ static int nic_register_interrupts(struct nicpf *nic) dev_err(&nic->pdev->dev, "Request for #%d msix vectors failed, returned %d\n", nic->num_vec, ret); - return 1; + return ret; } /* Register mailbox interrupt handler */ -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel