From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A64EC433F5 for ; Mon, 25 Oct 2021 17:05:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D04860EE3 for ; Mon, 25 Oct 2021 17:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D04860EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8bHKexG7hkg65JyPR3bzScVLCw1Seo7fikCSelw2gEw=; b=Ekq7CoCfQ5zZh5 EzjaBpmwAoT72AnLfQTq3Lflqo3l3WOMjaw0soLbnhLlgv4397W6eDTXalHQuaXUc1UZufhcQ9S07 0avvV8/rCwZVnmWQ6EJw0IbUZ2ZlwD36AL5headbbekrV1spS8XYEMvmEDqOHHaDxmtHDW+bH5+yV 6WxG4VjW9O+I+T4x3TjZcpPCicig8WAP/6+lHwDhjOcL9H+6ROLBHuUaTBzhZb2T2+0DlSDX/x/5K 3eZgOUMY8Lf8oGPC2vE/+GnvcwgPk4ql6rzmP7fbDiet3P0tdhNEL0NFDZssYgyHfyKIBk366MtSY WRMjigk0wKdTqVNNKSdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf3Nr-00HAFB-Lw; Mon, 25 Oct 2021 17:03:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf3LY-00H8rE-4O for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 17:01:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED89360F22; Mon, 25 Oct 2021 17:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635181275; bh=rnDD4WDFpKG1cuRhyxUS8s2pHW8MRe+5G+WBOMj0Oj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kM7Y4KKCZyYEDlQwEYz/QgSuvgGZGLBFU/BO5UnfPprShjN/N/JkOIusg/eCgsttd BlEJU+ed9/Zy5nw2EafIMbL0Dx0lbsg+wP0byZFa+6ZLK0KqemH+SwdaWaw3HJ//dn q/4y4Bsef1qGvxaFWhOpw1mEwEw0CGg9x7td5/hIzj9Py9yS1R/yn4AwrGyOeN18Em s68z/3LZnVeUqd7bcoMG+cJ8drXhMkK2XAW2Hil4MHytrA0kjtZwcZJoRxPS/oluKn ZhpxTXvCdmV0zIAt3rXhafA/CjDDRCAqy2JCOaVJt/FjZNAYdX0NSNchFJqJ4MOPGr WBtwv932WwoZw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , "David S . Miller" , Sasha Levin , sgoutham@marvell.com, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 4/7] cavium: Fix return values of the probe function Date: Mon, 25 Oct 2021 13:00:59 -0400 Message-Id: <20211025170103.1394651-4-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211025170103.1394651-1-sashal@kernel.org> References: <20211025170103.1394651-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_100116_243925_7EC98C2C X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zheyu Ma [ Upstream commit c69b2f46876825c726bd8a97c7fa852d8932bc32 ] During the process of driver probing, the probe function should return < 0 for failure, otherwise, the kernel will treat value > 0 as success. Signed-off-by: Zheyu Ma Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index 99eea9e6a8ea..0fbb0dee2dcf 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c @@ -1223,7 +1223,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) if (ret < 0) { netdev_err(nic->netdev, "Req for #%d msix vectors failed\n", nic->num_vec); - return 1; + return ret; } sprintf(nic->irq_name[irq], "%s Mbox", "NICVF"); @@ -1242,7 +1242,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) if (!nicvf_check_pf_ready(nic)) { nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0); nicvf_unregister_interrupts(nic); - return 1; + return -EIO; } return 0; -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel