* [PATCH] firmware: arm_ffa: remove unused 'compat_version' variable
@ 2021-10-26 8:33 Arnd Bergmann
2021-10-26 13:21 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-26 8:33 UTC (permalink / raw)
To: Sudeep Holla, Jens Wiklander
Cc: Arnd Bergmann, Marc Bonnici, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added ffa_compatible_version_find() function causes a
build warning because of a variable that is never used:
drivers/firmware/arm_ffa/driver.c:180:6: error: unused variable 'compat_version' [-Werror,-Wunused-variable]
u32 compat_version;
Fixes: 8e3f9da608f1 ("firmware: arm_ffa: Handle compatibility with different firmware versions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/firmware/arm_ffa/driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c
index 12f4c87c4555..14f900047ac0 100644
--- a/drivers/firmware/arm_ffa/driver.c
+++ b/drivers/firmware/arm_ffa/driver.c
@@ -177,7 +177,6 @@ static struct ffa_drv_info *drv_info;
*/
static u32 ffa_compatible_version_find(u32 version)
{
- u32 compat_version;
u16 major = MAJOR_VERSION(version), minor = MINOR_VERSION(version);
u16 drv_major = MAJOR_VERSION(FFA_DRIVER_VERSION);
u16 drv_minor = MINOR_VERSION(FFA_DRIVER_VERSION);
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] firmware: arm_ffa: remove unused 'compat_version' variable
2021-10-26 8:33 [PATCH] firmware: arm_ffa: remove unused 'compat_version' variable Arnd Bergmann
@ 2021-10-26 13:21 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2021-10-26 13:21 UTC (permalink / raw)
To: Arnd Bergmann, Jens Wiklander
Cc: Sudeep Holla, linux-arm-kernel, Arnd Bergmann, Marc Bonnici,
linux-kernel
On Tue, 26 Oct 2021 10:33:50 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added ffa_compatible_version_find() function causes a
> build warning because of a variable that is never used:
>
> drivers/firmware/arm_ffa/driver.c:180:6: error: unused variable 'compat_version' [-Werror,-Wunused-variable]
> u32 compat_version;
>
> [...]
Applied to sudeep.holla/linux (for-linux-next), thanks!
[1/1] firmware: arm_ffa: remove unused 'compat_version' variable
https://git.kernel.org/sudeep.holla/c/01537a078b
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-26 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 8:33 [PATCH] firmware: arm_ffa: remove unused 'compat_version' variable Arnd Bergmann
2021-10-26 13:21 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).