From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA58DC433EF for ; Tue, 26 Oct 2021 17:18:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB6796103C for ; Tue, 26 Oct 2021 17:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AB6796103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U4S3lhfUrWMA7TJB+JHJJFa7rA5igCgfqpIwehB7XFU=; b=LaL1i3BtzdOeRi ewnju4rlGUCuAcUS5dxa4U9iTpkk5FHhN8btpOzwRap6yVo0Ww3pJG4O1+NvsA3af011c/eqzvsHv CMsNTxR55I50QMVteVqVwbcR64jzQD7GGNFyhL7sMLQzpdXWG/E72oWXTj7NXcAItsCPPa5twyiUW pyNvfhiqqYW8uyBJH73Q0yIMq3AuExh5rZGI0jzYwtkXd1n4RuUhJLyMZF0BaVDcCBOVfCgF0szCG gJwXHIMoVTQTGQj2DCJqQSDD0wkupGt6nXvqmtsRN8J1Go8gnRJiQdPa17HZeNO/PzIRiH1dV17Sb 1/wW6l7vwZ3M/5NolFEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfQ4V-002awl-0I; Tue, 26 Oct 2021 17:17:11 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfQ4R-002awH-AF for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 17:17:08 +0000 Received: by mail-pg1-x52e.google.com with SMTP id s136so160668pgs.4 for ; Tue, 26 Oct 2021 10:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jS/Bb8HlBeXqBieknFa/sF/Lj+vFn0yJ+1yyDaWDOro=; b=SlbA97RgFmReoxDo2sQ4uaMAJ1WFI/4jMnoGIQG+HMpFaWq8WZVWBYz3HE7O19AAhI N9AGWBiYUy+cDOfw3nlYPFSOcRBlDPjNwTJTvB96MMZT3UHHaap4Qoh2XJTHzL4WYbRn thoBlvHlxlooKrUCBZjGCXL3NJoBML/xdDfMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jS/Bb8HlBeXqBieknFa/sF/Lj+vFn0yJ+1yyDaWDOro=; b=P6VVN7cncNSmF3QfWcNNqJRclOqixSdrpXm9nfXP49LQv5AGhRDxBbtTNR8nWQxVeQ OU90dbX6JMOxeFNXuWEMh+Znv66jPlCNRKvx4cSrw2dRYUbIx1I2pGrSuCIFZAmxR1Nz Yi440e3HizVdCbJWNmfTHdvGghYAaWThjH42+Mx2nrYlIo4zJPOmOue4WOcjQ52AVGI1 Nu36Cz1V4O5Hu3oGdPscLSRjEGKHdYtv/6gFQZfeVBZGHuYFMRdVANzsUChINBp0Lg8q oQiiMA41u4TQxqE/KTgSr2XBbrWMHwujKHu7JVn5MXnKTHg4DLsro7j6TW5szPIK2hQd MPLQ== X-Gm-Message-State: AOAM530AIdpT6pjI0G9Y9N8+2ZjvOX/0Yie8KwCcUFofSfMwjhJSgbJH JCgZiaCTte1VW6cqPQlyDIAO0RrqgblNfw== X-Google-Smtp-Source: ABdhPJy3wcwbRrDjTLAyIluKSke1KBFc/7opoyClAa4a0Aad9xqEBPHL5L/WIQBY6FtASto34NbzBw== X-Received: by 2002:a05:6a00:b92:b0:47b:e437:9ba with SMTP id g18-20020a056a000b9200b0047be43709bamr18624429pfj.39.1635268626307; Tue, 26 Oct 2021 10:17:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u193sm18979323pgc.34.2021.10.26.10.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 10:17:05 -0700 (PDT) Date: Tue, 26 Oct 2021 10:17:05 -0700 From: Kees Cook To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: stackprotector: prefer compiler for TLS based per-task protector Message-ID: <202110261015.D992D69@keescook> References: <20211021142516.1843042-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021142516.1843042-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_101707_376033_AA798ED4 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 21, 2021 at 04:25:16PM +0200, Ard Biesheuvel wrote: > Currently, we implement the per-task stack protector for ARM using a GCC > plugin, due to lack of native compiler support. However, work is > underway to get this implemented in the compiler, which means we will be > able to deprecate the GCC plugin at some point. > > In the meantime, we will need to support both, where the native compiler > implementation is obviously preferred. So let's wire this up in Kconfig > and the Makefile. > > Cc: Kees Cook > Cc: Nick Desaulniers > Signed-off-by: Ard Biesheuvel With the v3 GCC patch[1], this works for me. Thanks! Acked-by: Kees Cook And since this is doing a compiler feature-test, this can get landed without waiting for GCC, IMO. -Kees [1] https://lore.kernel.org/linux-hardening/20211026081836.3518758-2-ardb@kernel.org/ -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel