From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF84C433EF for ; Wed, 27 Oct 2021 11:28:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0845260E76 for ; Wed, 27 Oct 2021 11:28:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0845260E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y3x0iU6oF7oakXzogDY5S6gtnMdg9pHu7V/20nb0kOs=; b=Ivucj6rc31wezE Y+2du8YB2z9Woev7YCw9JecVIs8Rbot9MqymB+bDw0nIHl0wqeH1LxN+YYtUfTRIa7GEfT+pxCDhH mISNFUKRw+A4/sWHBU5cWLgO+oAqaZwPYBCDAaaa2bOdWhtFVYHwblYHZb7rAPRMmKwtorTnLNZEk d5d1FFFL8pFAajR8Yc2Vg2QOUIYla5hLBJd0oPXwZ15wMuqZaV73/VJGX40Xc0yvUI4Bcz2lEpgJy GLUKcw+3AtVULxKSrczhNf1LBBLPk9uvG7qzNSjcVLUdUZvj5Poyv0xH3Yclexun3ARtksk+aF3JK aKR3x4fz+M2q0QTZWg2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfh5Q-004hry-Sr; Wed, 27 Oct 2021 11:27:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfh5N-004hr6-Ey for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 11:27:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E4191FB; Wed, 27 Oct 2021 04:27:11 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.72.240]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6CBE3F73D; Wed, 27 Oct 2021 04:27:09 -0700 (PDT) Date: Wed, 27 Oct 2021 12:26:58 +0100 From: Mark Rutland To: Nicolas Saenz Julienne Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maz@kernel.org Subject: Re: [PATCH] arm64: Select POSIX_CPU_TIMERS_TASK_WORK Message-ID: <20211027112658.GA54628@C02TD0UTHF1T.local> References: <20211018144713.873464-1-nsaenzju@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211018144713.873464-1-nsaenzju@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_042713_577362_A3D90A87 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [adding Marc Z to Cc, since this affects KVM] On Mon, Oct 18, 2021 at 04:47:13PM +0200, Nicolas Saenz Julienne wrote: > With 6caa5812e2d1 ("KVM: arm64: Use generic KVM xfer to guest work > function") all arm64 exit paths are properly equipped to handle the > POSIX timers' task work. > > Deferring timer callbacks to thread context, not only limits the amount > of time spent in hard interrupt context, but is a safer > implementation[1], and will allow PREEMPT_RT setups to use KVM[2]. > > So let's enable POSIX_CPU_TIMERS_TASK_WORK on arm64. > > [1] https://lore.kernel.org/all/20200716201923.228696399@linutronix.de/ > [2] https://www.spinics.net/lists/linux-rt-users/msg24860.html Trivial nit: could we please make that second link: https://lore.kernel.org/linux-rt-users/87v92bdnlx.ffs@tglx/ > Signed-off-by: Nicolas Saenz Julienne Regardless, this makes sense to me, and given you've tested it: Acked-by: Mark Rutland Thanks, Mark. > > --- > > This was tested by running all relevant kernel timer self-tests and > making sure KVM still works as expected. > > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 789036cf74f5..ce0d0d254542 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -191,6 +191,7 @@ config ARM64 > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select HAVE_REGS_AND_STACK_ACCESS_API > + select HAVE_POSIX_CPU_TIMERS_TASK_WORK > select HAVE_FUNCTION_ARG_ACCESS_API > select HAVE_FUTEX_CMPXCHG if FUTEX > select MMU_GATHER_RCU_TABLE_FREE > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel