From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F957C433EF for ; Wed, 27 Oct 2021 17:00:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D966960F6F for ; Wed, 27 Oct 2021 17:00:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D966960F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=outDjnP9vd+BXA6bOtPNy1EcCzxqJ56PjwkkW84InzE=; b=Zr5sYs0yUO7Kts dH1CQnrZrEc3xeEIVcZDfKzuDbqErKQotv5PsbrIwOChxTsOdABP784TOo4MeHA69lqZVsG1J+0Ni +kEe3HK4lq7s9YMc4KypWaPuhhyTrwBRcUpNnaBjL9ZKhQ+MlrGfIKBEfDqlwlhDiwj83aoTro+Bh alxMl1aYvY94AVHizQNbvasd95kLBUFnwfiYw1z4sfWlTx0x47AKDBoF4ByhHPJ32LMXF2Vybu791 WDL41uAFct7lbfLxiVQY7P2vn9AriCtrIWSm09OfCzXoSOFkwuGD3XWmhgEjQbAsxijrfvrdju+Pr d/gJvnkjexqohmcJk4iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfmGW-005Wvc-HY; Wed, 27 Oct 2021 16:59:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfmGS-005Wur-Km; Wed, 27 Oct 2021 16:59:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8962560EDF; Wed, 27 Oct 2021 16:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635353939; bh=kaTwXIJN40QCdVhjU8t/SSdOu1JqzIHQJoWDXuNybm0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PA786h6onPARN5DmpCKcVlgIhdSBBgu5ndzyI6U+HKZ1g/MA5ycb5ijyGIiMzzQKF u87j4x6sL3i9EluMCuzknSv1hL0GJ57rkRx60UV5/FQ9YmfB22CuCH2pcd5uceVNvA EUR1nZ0y7WK6lw7hTzQk2P9j5TbbT1zdnTR+7LfJNX/9dajtJOFIR9T6/S0PIbpI/t HRg3xpUPL40GcJRSGCMzK4quK/+Du3fAhmUYq8AqwMZ4dEqE4aqS6Clvm1lpvS9u8U vJc0lfGe7ApcWkhkHzaKlt7eQsOK2LhQ0t6ZUVUoKmnCGpU9JA+E2UMXdKsKsXANN5 owBvlYRnkpNCw== Date: Wed, 27 Oct 2021 11:58:57 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Rob Herring , Jim Quinlan , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , Nicolas Saenz Julienne , Mark Brown , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Florian Fainelli , Bjorn Helgaas , Saenz Julienne , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v5 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Message-ID: <20211027165857.GA229979@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_095900_728079_24F2AEE4 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 26, 2021 at 05:27:32PM -0400, Jim Quinlan wrote: > I don't think it matters but our PCIe controllers only have a single > root port. Just to kibitz, and I don't know anything about the DT binding under discussion here, but I would prefer if DTs and drivers did not have the "single root port" assumption baked deeply in them. I expect some controllers to support multiple root ports, and it would be really nice if the DTs and drivers all had similar structures with the single-root-port controllers just being the N=1 case. For example, some drivers put their per-root port stuff in *_add_pcie_port() functions, which I think is a nice way to do it because it leaves the door open for calling *_add_pcie_port() in a loop. Ironically, the only driver I see that looks like it currently supports multiple root ports is pci-mvebu.c, and it doesn't have an _add_pcie_port() function. Having this sort of consistent structure and naming across drivers is a huge help for ongoing maintenance. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel