From: Guenter Roeck <linux@roeck-us.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning
Date: Wed, 27 Oct 2021 10:31:14 -0700 [thread overview]
Message-ID: <20211027173114.GA2327649@roeck-us.net> (raw)
In-Reply-To: <20211027123135.27458-1-zajec5@gmail.com>
On Wed, Oct 27, 2021 at 02:31:35PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This fixes:
> drivers/watchdog/bcm63xx_wdt.c: In function 'bcm63xx_wdt_ioctl':
> drivers/watchdog/bcm63xx_wdt.c:208:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
[reluctantly]
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
... because the driver should really be converted to use the watchdog subsystem,
by someone with the necessary hardware to test it.
Guenter
> ---
> drivers/watchdog/bcm63xx_wdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/bcm63xx_wdt.c b/drivers/watchdog/bcm63xx_wdt.c
> index 7cdb25363ea0..56cc262571a5 100644
> --- a/drivers/watchdog/bcm63xx_wdt.c
> +++ b/drivers/watchdog/bcm63xx_wdt.c
> @@ -207,6 +207,8 @@ static long bcm63xx_wdt_ioctl(struct file *file, unsigned int cmd,
>
> bcm63xx_wdt_pet();
>
> + fallthrough;
> +
> case WDIOC_GETTIMEOUT:
> return put_user(wdt_time, p);
>
> --
> 2.31.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 12:31 [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning Rafał Miłecki
2021-10-27 17:28 ` Florian Fainelli
2021-10-27 17:31 ` Guenter Roeck [this message]
2021-10-27 17:39 ` Florian Fainelli
2021-10-27 20:40 ` Rafał Miłecki
2021-10-27 22:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027173114.GA2327649@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=wim@linux-watchdog.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox