From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D723DC433EF for ; Thu, 28 Oct 2021 07:27:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A20C1604AC for ; Thu, 28 Oct 2021 07:27:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A20C1604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iDAOs/mNygZKeqGAvr6LhG1tS6L4ci9j7QNuXdr2NZA=; b=yfsSnvih7/5nM6 zAYGUX2HOdaMMVtwP+FGDkh5EP3CclGbu7X7s5+hK137nT0Dm/XIdJ136j6wJ0q7gGS6vFJvdYSMe wl6DjzGR9u3smw1KuAUgGzYiCmztNDQpELMFipoiPOpOzmYV+uTsQj9CHI3x/Ci3mSU/9MRYcBNJG WorXgVDeGamEjxIBOr22DQxKxebexfIwwYPsxOzZAv0AA+ZYIzfKScCDdj1t2/01L6N1JpLd0RwlF lueHSsni/V++bCDIoewB1znXu+NuhQgiODF0umjpzx481Aje6N/eMgCRDP/FaejHfy8JZ/tKrPktS ZTJV3FWzDMZx1HlVtYZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfzns-0076Ww-2n; Thu, 28 Oct 2021 07:26:24 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfzno-0076WB-RR for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 07:26:22 +0000 Received: by mail-lf1-x12b.google.com with SMTP id x27so11620541lfu.5 for ; Thu, 28 Oct 2021 00:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=An+PWLgm9KGN3ZMc6V12HECPGYxxsybsWas2GAbfS9c=; b=LcKx75XoCzDyv0KsxRa8EIVtTggERMVMVW374pW7DAVBNZ33LF7adCQ9RGECxrFB+w yJHwxBiT2dYqM4p8BPRy9nKSkAl5p3Uo7C42tASPiUJ72SrmzFH7CQVs1k+qVXC3F1VF skPF9xEF8L8upTlOi5AWdiT5t4piblTAtqXzFgrleKRlndDTTv4OreEfSdkUNXvrTS7s K5DWdozMtt9tMGFKDYXJLPmnrp7lFA+s2nf4OoIyF/wisNVGYbvA/2hYTbLPICeMfK+J ooFNAR7Z3lBu41WoefUsrnQoi1N9x2aBlQ+zKCwfMrBSBYijUsRnxyiV1YbF3on7iE9u bkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=An+PWLgm9KGN3ZMc6V12HECPGYxxsybsWas2GAbfS9c=; b=CpTmSpb8KdVxnvXj/ibuqPHz3n5+SXsKo6Iw1KUkafu+Kc8gnbtClaGUxmrnyk3wUH /WuShZkHNY1P/+LZ4d0t1k0fIRgj4KTMAbLpHsKjSXboqN3C3rZxvMx4hEMsmhLHjCAj l2zO0yWBuidsT2VhB52aWNkjzHo5Lb9fo+TXrAJhAPifsmHwRaUPRlGosPxSvZYqsCdc 3UKmsryTh5ifCZy/MuHp3P0l71WpwjYNfiO/zR2OsEXzCY8HwyaIp6UYlogiYQj7XLN6 YT+5/hVR8bULCxGrQwCdamL7Iy+nqPQvCnDtA8eDUUkeu0TlN7r+PZFggBlm2mbAZIJW AvfA== X-Gm-Message-State: AOAM533M7idFmyRLfmQw3PwfDy+uzs4FtDtEhTJrEn4kpKzRveHEaS7Q WYSqfPhtVjkXV9YMf3SEO/HPcww+D70Wjg== X-Google-Smtp-Source: ABdhPJyfOzJGwTUDwgcZTLmFS1lc6/QeQ+Ig43q40Kd5rQQFpKZziM4sJzXi3z7oppp69E6pL9tIPQ== X-Received: by 2002:a05:6512:3501:: with SMTP id h1mr2607048lfs.446.1635405978604; Thu, 28 Oct 2021 00:26:18 -0700 (PDT) Received: from mobilestation ([95.79.132.211]) by smtp.gmail.com with ESMTPSA id r7sm226300lfc.106.2021.10.28.00.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 00:26:18 -0700 (PDT) Date: Thu, 28 Oct 2021 10:26:16 +0300 From: Serge Semin To: Brad Larson Cc: Serge Semin , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Message-ID: <20211028072616.p3mazud3vi5jgynk@mobilestation> References: <20211025015156.33133-1-brad@pensando.io> <20211025015156.33133-5-brad@pensando.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211025015156.33133-5-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_002620_916154_5AE1A05A X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Brad The patch name "dt-bindings: spi: Add compatible for Pensando Elba SoC" doesn't mention to what bindings it is referring to. For the sake of having a more representative git log I'd suggest at least to add "cdns" vendor name in the title, like: "dt-bindings: spi: cdns: Add ..." Otherwise it's impossible to understand to what bindings you're adding a new compatibility especially seeing you are doing the similar thing for the DW SPI in the next patch. -Sergey On Sun, Oct 24, 2021 at 06:51:49PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0e7087cc8bf9..d4413eced17a 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -20,6 +20,7 @@ properties: > - ti,k2g-qspi > - ti,am654-ospi > - intel,lgm-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -38,7 +39,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel