From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B23FC433EF for ; Thu, 28 Oct 2021 07:54:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF7B960724 for ; Thu, 28 Oct 2021 07:54:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EF7B960724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iHtmFa2MURwxA70QNdjPODreyZWwKvOyrzo6VXYfCig=; b=AplEnL3PIpOGp2 NTGk4zHOjTpMX4RTWVESM5r1VgMIeZv7lc2jHII9UdpYKo5M2CEzG2ZhClCYPBhSgdvoz8fe2BvsN dH5Ebs4fD/ChFTi+6tKpTBTxeiH35rnEuhGXeYM3RqgI85U8lXU8iiiI9MpIT8xr9Mpj/yVS8neKE 4KeHhTRJ6aIAYfVkzXJv2sF5s+vJ2DumZtiaxfl4FtMdmaZme8/0ivGxZUlpIZrK9esUS9q8CxJC8 EbYS/DVlTv7zzLCJvISfEWcpmiahnZTFAs9IEXm44kIGDQTu3n46Kaz7U5qd1K3iSUY2GStT47mGm HO8YgiZyQlFKtUaFJSpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg0DH-007AG0-On; Thu, 28 Oct 2021 07:52:39 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg0DE-007AF8-5R for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 07:52:37 +0000 Received: by mail-lj1-x22c.google.com with SMTP id q16so9224025ljg.3 for ; Thu, 28 Oct 2021 00:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ncm5RLVfG8Rch5oTebv4WuqYF8vVKQ52wGDqN1K88ZM=; b=XPQxQDLke3l5szkLZPojr3KA/yAbpCVzhmPqHXsUgV8/HrWQ2WfDoY3MgfHZPHbBpQ CLqTxicf7xUfuhW4SSohyvbHRyQIVTQGd/JI4lpZgVIVhuviU6AbSw3MD+EeI0leQSi9 SYy6/wM7CCeVbZxolMqvTOSOSILX6b3ASscZ04+LaTMaSDwiXOyJw1rw94YZRg5axye+ v0uvVjx/89YMUnvYHI6V97sNc8I3FBHjejkSzDG5fj+9uC0AfCyGSokShZaBI43GhEtm t0ZzQYkZn7Zaeuy9e3JyMotNvsc8Gj5XePCWjuALpQKDGftqUyEaYGqDNWEqd7vBj+Bd IFnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ncm5RLVfG8Rch5oTebv4WuqYF8vVKQ52wGDqN1K88ZM=; b=fugrmoCQSJo8tt+X6WEFpe3LwjYn+jBDmoyIQLHW9Unp0baXxaHfCrjHVacRmHPqo8 i0obORbthL4LLyDZiMdv8ZRtI1yCeGyTISLt6vTFFivAAF4tdM1qkEsq7zU+G5LKRZQM KdaCHy2kA54F3uJ99qM5cbrhfwZl9VqkRAvxu1tO968KIrgkuo4GbjPKdWO+ENnQp3QO U8NoV6MJnb6PTq3BKS2ELMN69xVSQIK18FqLkxtJ7NFDXOMxiGkHKfNBa8GABH3ch8Ar K+Ou7M7fAXEIsrfZhVIx1l7xVS9oNJdMUEaO7n4m4VOM0MwoocD/k2pmtJBQmPLf4XSO FKFA== X-Gm-Message-State: AOAM530XyUvwEDVxOdpG/hIYoaUnO9mFLryNuOGmiHnQTY9Rir2KVPKs FzLQGCQbPutoFdVN3ubsQdA= X-Google-Smtp-Source: ABdhPJzWaKruJXPS+XLQZC8j2kvpnKqV1KxSNlUhCxXyQhNNHpe58LURH79lwVIK+N6vl0Qpy8ahLw== X-Received: by 2002:a2e:3007:: with SMTP id w7mr3171650ljw.152.1635407553444; Thu, 28 Oct 2021 00:52:33 -0700 (PDT) Received: from mobilestation ([95.79.132.211]) by smtp.gmail.com with ESMTPSA id k16sm208982ljq.83.2021.10.28.00.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 00:52:33 -0700 (PDT) Date: Thu, 28 Oct 2021 10:52:31 +0300 From: Serge Semin To: Brad Larson Cc: Serge Semin , Rob Herring , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings Message-ID: <20211028075231.47ihqwopu5qodhl7@mobilestation> References: <20211025015156.33133-1-brad@pensando.io> <20211025015156.33133-6-brad@pensando.io> <20211028074945.rv2j5kgzk7yc2srr@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211028074945.rv2j5kgzk7yc2srr@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_005236_233912_FA6E5A42 X-CRM114-Status: GOOD ( 21.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 10:49:48AM +0300, Serge Semin wrote: > On Sun, Oct 24, 2021 at 06:51:50PM -0700, Brad Larson wrote: > > The Pensando Elba SoC has integrated the DW APB SPI Controller > > Please add the "dt-bindings: " prefix to the patch name and discard > the word "bindings" from the title as the submitting DT-patches > requires: > Documentation/devicetree/bindings/submitting-patches.rst > > > > > Signed-off-by: Brad Larson > > --- > > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > index d7e08b03e204..0b5ebb2ae6e7 100644 > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -73,6 +73,8 @@ properties: > > - renesas,r9a06g032-spi # RZ/N1D > > - renesas,r9a06g033-spi # RZ/N1S > > - const: renesas,rzn1-spi # RZ/N1 > > > + - description: Pensando Elba SoC SPI Controller > > + const: pensando,elba-spi > > AFAICS from the driver-part of the patchset it's not enough. You've > also got the syscon phandle, which needs to be reflected in the > bindings. That also makes me thinking that you didn't perform the > "dtbs_check" on the dts-files you were going to submit, > but for some reason discarded from this series (btw why?). Oops. Found it. The question regarding "dtbs_check" is still actual. -Sergey > If you did you would > have got an error of an unevaluated property detection. > > -Sergey > > > > > reg: > > minItems: 1 > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel