From: Jonathan Cameron <jic23@kernel.org>
To: "André Gustavo Nakagomi Lopez" <andregnl@usp.br>
Cc: lars@metafoo.de, vz@mleia.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call
Date: Thu, 28 Oct 2021 14:40:41 +0100 [thread overview]
Message-ID: <20211028144041.20407149@jic23-huawei> (raw)
In-Reply-To: <YXag5l4xBkGQH3tq@Andryuu.br>
On Mon, 25 Oct 2021 09:19:50 -0300
André Gustavo Nakagomi Lopez <andregnl@usp.br> wrote:
> clk_get_rate is not guaranteed to work if called before clk_prepare_enable.
>
> Reorder clk_get_rate, so it's called after clk_prepare_enable and
> after devm_add_action_or_reset of lpc18xx_clk_disable.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> Signed-off-by: André Gustavo Nakagomi Lopez <andregnl@usp.br>
Thanks. I tweaked the message a little and added a note that this was not
a fix for this particular platform. Good to avoid chance of cut and paste
into another driver!
Jonathan
> ---
> Change log V1 -> V2:
> -Fixed typo
> -Added appropriate Suggested-by and Acked-by tags
> drivers/iio/adc/lpc18xx_adc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
> index ceefa4d793cf..ae9c9384f23e 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -157,9 +157,6 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
> return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk),
> "error getting clock\n");
>
> - rate = clk_get_rate(adc->clk);
> - clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET);
> -
> adc->vref = devm_regulator_get(&pdev->dev, "vref");
> if (IS_ERR(adc->vref))
> return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref),
> @@ -192,6 +189,9 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> + rate = clk_get_rate(adc->clk);
> + clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET);
> +
> adc->cr_reg = (clkdiv << LPC18XX_ADC_CR_CLKDIV_SHIFT) |
> LPC18XX_ADC_CR_PDN;
> writel(adc->cr_reg, adc->base + LPC18XX_ADC_CR);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-10-28 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:19 [PATCH v2] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call André Gustavo Nakagomi Lopez
2021-10-28 13:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028144041.20407149@jic23-huawei \
--to=jic23@kernel.org \
--cc=andregnl@usp.br \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox