From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183AFC433EF for ; Thu, 28 Oct 2021 17:08:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0358610C8 for ; Thu, 28 Oct 2021 17:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D0358610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1p3fe5GDgwEdwn1yI0W3TyUPdThrCRuryAhNdzQqP+E=; b=TZh9rQA/yO2pRI 3bwecp3hDxN2Tm/DVmuDGkjTioPmn5wSfOz1t6VxfC/t3hoT8g/e+FhCCrwnuJuoysHZ2BtuXF+YI Zsv9v9vQbX8xYtKemmxdqiIUf9VBGCz/JAye41nkWZRz0xR1VJmZrdxUehn//2acjlk5rFFB4Yaf8 sCG2C10goBORElBVwHIWo0BcWFxMkKNOQ1SuJxV9r5SYu/Murb7ZhVCzKujAw8Q3Yf4UEP+fXJE/I 8H86CVE06XR9RRbV5Bw4E5S+T9451fo/aZ/3zkxj+P98kGm7XMmRsGi0iyAyr2DuGDD7A5Yk2ScYH z3RrZ+XzWjMrrC1pzKTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg8sN-008fwV-GX; Thu, 28 Oct 2021 17:07:39 +0000 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg8sJ-008fuq-Cf for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 17:07:36 +0000 Received: by mail-ot1-x32d.google.com with SMTP id o10-20020a9d718a000000b00554a0fe7ba0so3667745otj.11 for ; Thu, 28 Oct 2021 10:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gZBgjz3etReQLTYp9UvuJj0WkrqB5NTdLLhetv3xijo=; b=C06U+26Ot/OLH0XlOSu84+pH/2WwhGGpzP2pUvYa8eCny8+/OyEGUV7s+xYsb2rQIG kyNay3It4UiRk9NCzz7AcIn9e+qhQe3DRwuGJa9k7xsE8LEcxNd0a3HdalhDl8kQ3xrr 9MCPMc0j85G57l64mUVVvibVhj+r0FZX5yhjFPn4zoph5WrN4xW2jxBGXDWDwhHrD3Oc QeidVvZSpR/0H5AJqYlaw/RfC6WfKTigtNcoHo5iukngzNoh/3xWWSqyOyNzmmlZUe/s HGfxQ6d9yEHf3kyjjXOtPF/veqT6lkxCNrcyJlrfHyYGqLqpF9UnEfRXzb3Tid0u8GQ/ fc/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=gZBgjz3etReQLTYp9UvuJj0WkrqB5NTdLLhetv3xijo=; b=HzwJnSF+2ZfYNW5VJ58F1eYu2vi3mD4SDAXNcn13N0OGsWy4d6dx5Xaqa6D31kZQnv P8/p2kiZQGarkebpZpd0NqdMHFhc19e9O0oFabbmyBe0dkxirmAI4Ajxxm3K+ZJrqsg+ 4hi3jk8NnRuFB42nwtA/J9ex3BeTmtjOacbd5uJQd4sKqlzPZ/PT9Bb3y+ijxREqvC2s YuU8AiDAZP18HhHA/5u+aU5VmwkSBcOuKtK/q8E7yGGPLVCGCzgduos75McdtWy7Iz4N meEkPv1ZuROBvd0M2fmykZBtLGs0zLCpGsgf2yOOf0Q3T+0dKWhAPWCiaGQbya6eeMrp wfCQ== X-Gm-Message-State: AOAM531HQs972jjo+70hxfWrqYwZbc0TTR0Id4NTkRJ0jw31kUg82jBk p1txMPbBTCFc1nzcQgkI1So= X-Google-Smtp-Source: ABdhPJwqgUEP7rJvCkru1GLDfPLZkWmcZIcHmgnaF4zzZDcAPlCCxNbWKoRDKtOJpezhLekHQvxfxw== X-Received: by 2002:a9d:d84:: with SMTP id 4mr4332743ots.383.1635440854093; Thu, 28 Oct 2021 10:07:34 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p190sm1135256ooa.1.2021.10.28.10.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 10:07:33 -0700 (PDT) Date: Thu, 28 Oct 2021 10:07:32 -0700 From: Guenter Roeck To: Mark Rutland Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Message-ID: <20211028170732.GA507928@roeck-us.net> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021180236.37428-4-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_100735_467800_1AD1E3F6 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > check performed by handle_irq_desc(), nor the resolution of the desc > performed by generic_handle_domain_irq(). > > Use generic_handle_domain_irq() directly, as this is functioanlly > equivalent and clearer. > > There should be no functional change as a result of this patch. > Except for this compile error: arch/mips/kernel/irq.c: In function 'do_domain_IRQ': arch/mips/kernel/irq.c:114:26: error: unused variable 'desc' [-Werror=unused-variable] 114 | struct irq_desc *desc; Guenter > Signed-off-by: Mark Rutland > Cc: Marc Zyngier > Cc: Thomas Bogendoerfer > Cc: Thomas Gleixner > --- > arch/mips/kernel/irq.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > index d20e002b3246..1fee96ef8059 100644 > --- a/arch/mips/kernel/irq.c > +++ b/arch/mips/kernel/irq.c > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > irq_enter(); > check_stack_overflow(); > - > - desc = irq_resolve_mapping(domain, hwirq); > - if (likely(desc)) > - handle_irq_desc(desc); > - > + generic_handle_domain_irq(domain, hwirq); > irq_exit(); > } > #endif > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel