From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9721C433F5 for ; Thu, 28 Oct 2021 20:49:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FC7B60F21 for ; Thu, 28 Oct 2021 20:49:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FC7B60F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=UcOoYu9RFeWaqdesnoyHYU3YBQrAzcAWXZrF7SNBNPk=; b=JG1JG1KU63WHsf 7J2yIA+P9fqGyRNFbca5OwHGGcIRjPrjh99+kHAg+zwrXvgmJv3SdwKmmHqLTtAS8Q6Lc84ffLMy9 qR9+rh6eIWcqhOMcvXlpHLV+zWfhm6isCnqoATaTL2iWSkAWHK5q7fu8WIe+nQ6yVsSIbdGUSGXl0 bcko31btXGfiu0vRuY+lMRWtSs/TG9orc5lAPuJDsosh+3zzZSPzfXQfqtwL2SM2yaBYdR0MwZh+P O3X6RAqAyW8Sdq6Au2W8XZUmP5rUmDVDNHQfeovQ65HgtKthJBEUMs182NZFyQaJbT8iHpNm04WBd rdUUyy7yrxCJfOsmdLJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgCJe-0094Bn-QR; Thu, 28 Oct 2021 20:48:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgCJa-0094Ay-Uf; Thu, 28 Oct 2021 20:48:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3588D60F21; Thu, 28 Oct 2021 20:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635454078; bh=QIIErr9k/GQ8cPnA4NVe5+CaffoR9OvTQo8rGLm1sGY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fyCHgBKRLWVUiE7jSBydUg2K5TvD7NRO2xtSrG9BOGKjyGkvnVFUPekPQ9kBvqcU9 uAd4vG+FZ9sZFYEt+di/4wC7U4RsxhdmFJ9FVX6hchKmjCf4ba6ked5MLI0S76Wtje S4sAvfP2kCfIs/v5Y2Pt2gtLjvtYsLI2wY2xCtQ/mYNvRqSkaY7C08uFAc+TuF2G7X OnSfuz6FoHMXF9giGvL3RZijUjIN7BfY9ofuzF55Ei+Yapbc1yO6/WxIRlmoR4ImwP LHfIc5oHs6ck0Cn9k5Ai5cAthno++jwv8rElte0uKT6sGrDUqkRPg3P6cj0maPUraq H/5JO/h9LwilA== Date: Thu, 28 Oct 2021 15:47:56 -0500 From: Bjorn Helgaas To: Sergio Paracuellos Cc: Thomas Bogendoerfer , Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Message-ID: <20211028204756.GA293663@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_134759_050633_DA294097 X-CRM114-Status: GOOD ( 28.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 11:59:17AM +0200, Sergio Paracuellos wrote: > On Thu, Oct 28, 2021 at 11:34 AM Sergio Paracuellos > wrote: > > On Thu, Oct 28, 2021 at 11:24 AM Thomas Bogendoerfer > > wrote: > > > On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > > > > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > > > > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > > > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > > > > drivers become modules. > > > > > > > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > > > > > > Let's just export them. > > > > > > > > > > Signed-off-by: Yanteng Si > > > > > --- > > > > > arch/mips/kernel/mips-cm.c | 5 +++++ > > > > > arch/mips/kernel/mips-cpc.c | 1 + > > > > > 2 files changed, 6 insertions(+) > > > > > > > > > > > > > Reviewed-by: Sergio Paracuellos > > > > > > could we instead make the pcie-mt761 driver non modular ? Exporting > > > all MIPS specific stuff for just making an essential driver modular > > > doesn't IMHO make much sense. > > > > The driver is modular because I have been advised other times that new > > drivers should be able to be compiled as modules and we should avoid > > using 'bool' in Kconfig for new drivers. That's the only reason. I am > > also always including as 'y' the driver since for me not having pci in > > my boards has no sense... I am ok in changing Kconfig to be 'bool' > > instead of 'tristate', but I don't know what should be the correct > > thing to do in this case. Thoughts? > > I guess we also want the driver to at least be compile tested in > 'allmodconfig' and other similars... Sounds like the systems that actually use this driver require it to be built-in, and the only benefit of exporting these symbols is that we would get better compile test coverage. If that's the case, I agree that it's better to just make it non-modular. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel