From: Florian Klink <flokli@flokli.de>
To: Dennis Gilmore <dgilmore@redhat.com>
Cc: linux-rockchip@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion
Date: Mon, 1 Nov 2021 10:46:41 +0100 [thread overview]
Message-ID: <20211101094641.cseo7fvrzyzh2pkl@tp> (raw)
In-Reply-To: <20211029005323.144652-1-dgilmore@redhat.com>
Acked-By: Florian Klink <flokli@flokli.de>
On 21-10-28 19:53:19, Dennis Gilmore wrote:
>without ep-gpios defined u-boot does not initialise PCIe
>rockchip_pcie pcie@f8000000: failed to find ep-gpios property
>
>additionally set max-link-speed and pinctrl-names for completeness
>
>with this patch and the ones from Florian Klink applied to the dts
>file in u-boot sata drives show up in both u-boot and linux
>
>Signed-off-by: Dennis Gilmore <dgilmore@redhat.com>
>---
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>index 9c2b45012daa..1e4042a7fdc3 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>@@ -534,7 +534,10 @@ &pcie_phy {
> };
>
> &pcie0 {
>+ ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>+ max-link-speed = <2>;
> num-lanes = <2>;
>+ pinctrl-names = "default";
> status = "okay";
>
> vpcie12v-supply = <&vcc12v_dcin>;
>--
>2.32.0
--
Florian Klink
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-01 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 0:53 [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion Dennis Gilmore
2021-11-01 9:46 ` Florian Klink [this message]
2021-11-21 18:52 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101094641.cseo7fvrzyzh2pkl@tp \
--to=flokli@flokli.de \
--cc=devicetree@vger.kernel.org \
--cc=dgilmore@redhat.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).