From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBC5C433EF for ; Mon, 1 Nov 2021 09:48:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE4A600EF for ; Mon, 1 Nov 2021 09:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7FE4A600EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=flokli.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fTAj2DVuSRijIN/OJt5S2oyJ9OJ+H9tSmJKjMy+4g4M=; b=5EO87GzjT+LrGSsJbqkaXlmQ/n 4cN2nxB0lB9O/3wURDIIWUbsSx89fkchtRxFPjbPLL6uBCi56DDy0ZkbVPsDnXTDrPMU+agAB732j NOMUxycRKPlgVDZqk1E0FCf57dxh9dUOlj4qZZaVpinJP1D9BGc/AR2U058KDlx7E9Z8dqhlgqmug aZNEw1Vb2mCqeh2RL5l34zU5lvqyhtZotxEo+YG+3pgss1UejEF2EvPF6CH/mOa7ICZifHihl1Afi ZlVLYsCjX9IqM+U5oaL1tioNFN8V4O4n2WS3vxGI35A/IuYShpvgVYDVzQBA+HIlD4doj0fv64k06 E0a6zyYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTu1-00FrID-2f; Mon, 01 Nov 2021 09:46:53 +0000 Received: from mail.zeus.flokli.de ([88.198.15.28] helo=zeus.flokli.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTtw-00FrGG-Vn; Mon, 01 Nov 2021 09:46:50 +0000 Received: from localhost (dslb-094-221-236-183.094.221.pools.vodafone-ip.de [94.221.236.183]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: flokli@flokli.de) by zeus.flokli.de (Postfix) with ESMTPSA id 34FFE11E59DA; Mon, 1 Nov 2021 09:46:42 +0000 (UTC) Date: Mon, 1 Nov 2021 10:46:41 +0100 From: Florian Klink To: Dennis Gilmore Cc: linux-rockchip@lists.infradead.org, Rob Herring , Heiko Stuebner , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion Message-ID: <20211101094641.cseo7fvrzyzh2pkl@tp> References: <20211029005323.144652-1-dgilmore@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211029005323.144652-1-dgilmore@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_024649_218924_5A96FFD1 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Acked-By: Florian Klink On 21-10-28 19:53:19, Dennis Gilmore wrote: >without ep-gpios defined u-boot does not initialise PCIe >rockchip_pcie pcie@f8000000: failed to find ep-gpios property > >additionally set max-link-speed and pinctrl-names for completeness > >with this patch and the ones from Florian Klink applied to the dts >file in u-boot sata drives show up in both u-boot and linux > >Signed-off-by: Dennis Gilmore >--- > arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts >index 9c2b45012daa..1e4042a7fdc3 100644 >--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts >+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts >@@ -534,7 +534,10 @@ &pcie_phy { > }; > > &pcie0 { >+ ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; >+ max-link-speed = <2>; > num-lanes = <2>; >+ pinctrl-names = "default"; > status = "okay"; > > vpcie12v-supply = <&vcc12v_dcin>; >-- >2.32.0 -- Florian Klink _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel