Re: [PATCH v3 8/8] irqchip: Add Sunplus SP7021 interrupt controller driver

From: kernel test robot <lkp@intel.com>
To: Qin Jian <qinjian@cqplus1.com>, robh+dt@kernel.org
Cc: kbuild-all@lists.01.org, mturquette@baylibre.com,
	sboyd@kernel.org, maz@kernel.org, p.zabel@pengutronix.de,
	broonie@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 8/8] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Mon, 1 Nov 2021 16:27:59 +0800	[thread overview]
Message-ID: <202111011619.BZmnWfc7-lkp@intel.com> (raw)
In-Reply-To: <e29329c9ace46cdb79bd87bc3125d5666a5ad1b4.1635737544.git.qinjian@cqplus1.com>

[-- Attachment #1: Type: text/plain, Size: 4912 bytes --]

Hi Qin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pza/reset/next]
[also build test WARNING on robh/for-next clk/clk-next linus/master v5.15]
[cannot apply to tip/irq/core next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Qin-Jian/dt-bindings-vendor-prefixes-Add-Sunplus/20211101-140155
base:   https://git.pengutronix.de/git/pza/linux reset/next
config: sparc-randconfig-r011-20211101 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ca53c40693bc90c44e3ec4c95c7758d7342229e2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Qin-Jian/dt-bindings-vendor-prefixes-Add-Sunplus/20211101-140155
        git checkout ca53c40693bc90c44e3ec4c95c7758d7342229e2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_handle_ext_cascaded':
>> drivers/irqchip/irq-sp7021-intc.c:154:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     154 |         int ext_num = (int)irq_desc_get_handler_data(desc);
         |                       ^
   drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_irq_map':
>> drivers/irqchip/irq-sp7021-intc.c:212:76: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     212 |         irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i);
         |                                                                            ^
   drivers/irqchip/irq-sp7021-intc.c: At top level:
   drivers/irqchip/irq-sp7021-intc.c:217:6: warning: no previous prototype for 'sp_intc_set_ext' [-Wmissing-prototypes]
     217 | void sp_intc_set_ext(u32 hwirq, int ext_num)
         |      ^~~~~~~~~~~~~~~
   drivers/irqchip/irq-sp7021-intc.c:223:12: warning: no previous prototype for 'sp_intc_init_dt' [-Wmissing-prototypes]
     223 | int __init sp_intc_init_dt(struct device_node *node, struct device_node *parent)
         |            ^~~~~~~~~~~~~~~

vim +154 drivers/irqchip/irq-sp7021-intc.c

   150	
   151	static void sp_intc_handle_ext_cascaded(struct irq_desc *desc)
   152	{
   153		struct irq_chip *chip = irq_desc_get_chip(desc);
 > 154		int ext_num = (int)irq_desc_get_handler_data(desc);
   155		int hwirq;
   156	
   157		chained_irq_enter(chip, desc);
   158	
   159		while ((hwirq = sp_intc_get_ext_irq(ext_num)) >= 0) {
   160			if (unlikely(IS_GPIO_INT(hwirq) && TEST_STATE(hwirq, _IS_ACTIVE))) { // WORKAROUND
   161				ASSIGN_STATE(hwirq, _IS_ACTIVE, false);
   162				sp_intc_assign_bit(hwirq, REG_INTR_POLARITY, TEST_STATE(hwirq, _IS_LOW));
   163			} else {
   164				generic_handle_domain_irq(sp_intc.domain, hwirq);
   165			}
   166		}
   167	
   168		chained_irq_exit(chip, desc);
   169	}
   170	
   171	#ifdef CONFIG_SMP
   172	static int sp_intc_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
   173	{
   174		return -EINVAL;
   175	}
   176	#endif
   177	
   178	static struct irq_chip sp_intc_chip = {
   179		.name = "sp_intc",
   180		.irq_ack = sp_intc_ack_irq,
   181		.irq_mask = sp_intc_mask_irq,
   182		.irq_unmask = sp_intc_unmask_irq,
   183		.irq_set_type = sp_intc_set_type,
   184	#ifdef CONFIG_SMP
   185		.irq_set_affinity = sp_intc_set_affinity,
   186	#endif
   187	};
   188	
   189	static int sp_intc_irq_domain_map(struct irq_domain *domain,
   190		unsigned int irq, irq_hw_number_t hwirq)
   191	{
   192		irq_set_chip_and_handler(irq, &sp_intc_chip, handle_level_irq);
   193		irq_set_chip_data(irq, &sp_intc_chip);
   194		irq_set_noprobe(irq);
   195	
   196		return 0;
   197	}
   198	
   199	static const struct irq_domain_ops sp_intc_dm_ops = {
   200		.xlate = irq_domain_xlate_twocell,
   201		.map = sp_intc_irq_domain_map,
   202	};
   203	
   204	static int sp_intc_irq_map(struct device_node *node, int i)
   205	{
   206		unsigned int irq;
   207	
   208		irq = irq_of_parse_and_map(node, i);
   209		if (!irq)
   210			return -ENOENT;
   211	
 > 212		irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i);
   213	
   214		return 0;
   215	}
   216	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28757 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel