Re: [PATCH v7 5/7] PCI: brcmstb: Add control of subdevice voltage regulators

Mark Brown
2021-11-03T19:46:55Z

[-- Attachment #1.1: Type: text/plain, Size: 721 bytes --]

On Wed, Nov 03, 2021 at 02:49:35PM -0400, Jim Quinlan wrote:

> + for_each_property_of_node(dn, pp) {
> + for (i = 0; i < ns; i++) {
> + char prop_name[64]; /* 64 is max size of property name */
> +
> + snprintf(prop_name, 64, "%s-supply", supplies[i]);
> + if (strcmp(prop_name, pp->name) == 0)
> + break;
> + }
> + if (i >= ns || pcie->num_supplies >= ARRAY_SIZE(supplies))
> + continue;
> +
> + pcie->supplies[pcie->num_supplies++].supply = supplies[i];
> + }

Why are we doing this? If the DT omits the supplies the framework will
provide dummy supplies so there is no need to open code handling for
supplies not being present at all in client drivers. Just
unconditionally ask for all the supplies.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]