From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72BC5C433F5 for ; Fri, 5 Nov 2021 02:54:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37D1561207 for ; Fri, 5 Nov 2021 02:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37D1561207 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3zAiFCSY3tVq7HvNJ1teGm6KYqyXZ+m6+a94iTs3WhQ=; b=j5MhNhMlDU1XWi DL9bCAXkmnlLhy5d1FLvELJvJqMCT0RCZjc9yrD9UpOSjA2F6037d66/xDA7XQvd5FZwo9N/U57mF fBnubfzAOLqvSG29vOJddqROJl/wG0A5JGrWwB+69TjvhmvGfZE3rtxN8n+U7KtoXgJzJd06VlBW2 zFFdK5ymkwC59ZY1j8NhvI1sDD6oRV+msD2ySPj4ygeqZqwnMIGRWMTVtiHmjzm5JlO8u/INZH2eC 4B9BnLTw0lipJGUROl1Mns5VBFs9MQ263mNeEqQxwCe3sItWEEFIriv9c5OElk6V2V03KI8lWmVzJ om6P9mfFdg2vImxOl7iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mipKn-00AR5M-Tg; Fri, 05 Nov 2021 02:52:06 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mipKj-00AR4P-Vj for linux-arm-kernel@lists.infradead.org; Fri, 05 Nov 2021 02:52:03 +0000 Received: by mail-oi1-x22b.google.com with SMTP id bg25so11793934oib.1; Thu, 04 Nov 2021 19:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rmahxTkcmLTTUsDx1Lk4JadyLl4Uj+83r4z6uZU3XFs=; b=A/2YuRQiluZrxEIaHsOQFWi/K/GvPb0UFK1t9GW8yKz2hJna+Aqy/J4hR9Ygf+xDB3 OeVHDAm4LD5+jMd6rUa9yvh7RgHb7AFtDcBuRLqFS1yFnbZm5tw4TnHS3fpyUuS9j/2v lAgejIhGQJIPJF7N65IIcYAopIbIt2z9MM26VS3/t6AIWsNtMusvF2m0Jw0jPOmv7OW7 M0u/rRovcJlk7uMKMw9UtU9wDjmrbc567IlVQxrAb+AYkZeBd40xaYf9LDN5M8JeKW1q W6PgmMBHIjrQEZ/sikrwQSBdrCGQyo8L08Jd8ZPqPRsNn7E/raNDn32OB5ssP6IPaxZy Q5bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=rmahxTkcmLTTUsDx1Lk4JadyLl4Uj+83r4z6uZU3XFs=; b=RcwMFonMwA9nvfLnC4UqkU7s2vCW74aeLMdLHiJQHICxuGKhzfAfNTzRbxThsGpPaO mM9g4YkYOyRU/OwKdsb/Kg9nz6zYT4M8oiLkbG1KHUQi8ueQxDumqTGUvVvzapXhhD7C XStS+bs+FHaH20BjFqIm+s2sP1fL11vfJRPX+v4wFoejQyRq62A4hN6/9dIJ7n9PiLKH 1d5ZQvgZVXXtR6Wnp/9Fuv2wZ6G53uOVph4ohmTXhE57Gfhiz04zPF+6B0FdJkJQH4XI HkGErGlKUQXDZX+j3A4CYPHSiVH32lNuyRnEVV6OaMiqv6crswmNVs1oOL9D8gVx6q7v OMkA== X-Gm-Message-State: AOAM532FOOeFvs4u1XmsU9GtA4LbZAjMuwJtMgUKYNIhgRdXkFbjX416 UzHp0twNX79pKTN42ShubeE= X-Google-Smtp-Source: ABdhPJyDFxYMVOtiRtft75YlF0cogHcG/uGRvl5sP+t1qmyDomW/q60sd2WZuuEZ60pIRVkx8RyjpA== X-Received: by 2002:aca:41d5:: with SMTP id o204mr19518908oia.41.1636080717716; Thu, 04 Nov 2021 19:51:57 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id v130sm1908932oie.34.2021.11.04.19.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 19:51:57 -0700 (PDT) Date: Thu, 4 Nov 2021 19:51:55 -0700 From: Guenter Roeck To: Florian Fainelli Cc: linux-kernel@lists.infradead.org, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Arnd Bergmann , Linus Walleij , open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] bus: brcmstb_gisb: Allow building as module Message-ID: <20211105025155.GA2922689@roeck-us.net> References: <20210924191035.1032106-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210924191035.1032106-1-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_195202_054493_7A679CA4 X-CRM114-Status: GOOD ( 23.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 12:10:34PM -0700, Florian Fainelli wrote: > Allow building the Broadcom STB GISB arbiter driver as a module, however > similar to interrupt controller drivers, don't allow its unbind/removal > since it is not quite prepared for that and we want it to catch bus > errors all the time. > > Signed-off-by: Florian Fainelli Hmm, did you actually test that ? Building mips:allmodconfig ... failed -------------- Error log: :1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp] ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined! Guenter > drivers/bus/Kconfig | 2 +- > drivers/bus/brcmstb_gisb.c | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index a5b96f3aad67..9cfeae3fc244 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -30,7 +30,7 @@ config ARM_INTEGRATOR_LM > found on the ARM Integrator AP (Application Platform) > > config BRCMSTB_GISB_ARB > - bool "Broadcom STB GISB bus arbiter" > + tristate "Broadcom STB GISB bus arbiter" > depends on ARM || ARM64 || MIPS > default ARCH_BRCMSTB || BMIPS_GENERIC > help > diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c > index 6551286a60cc..4c2f7d61cb9b 100644 > --- a/drivers/bus/brcmstb_gisb.c > +++ b/drivers/bus/brcmstb_gisb.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (C) 2014-2017 Broadcom > + * Copyright (C) 2014-2021 Broadcom > */ > > #include > @@ -536,6 +536,7 @@ static struct platform_driver brcmstb_gisb_arb_driver = { > .name = "brcm-gisb-arb", > .of_match_table = brcmstb_gisb_arb_of_match, > .pm = &brcmstb_gisb_arb_pm_ops, > + .suppress_bind_attrs = true, > }, > }; > > @@ -546,3 +547,7 @@ static int __init brcm_gisb_driver_init(void) > } > > module_init(brcm_gisb_driver_init); > + > +MODULE_AUTHOR("Broadcom"); > +MODULE_DESCRIPTION("Broadcom STB GISB arbiter driver"); > +MODULE_LICENSE("GPL v2"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel