From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E1AC433F5 for ; Fri, 5 Nov 2021 08:15:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E5D260F39 for ; Fri, 5 Nov 2021 08:15:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E5D260F39 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NXkDPIhPy9jRRiIGREBo8CP3060aN5LpGCUTxqzH7cc=; b=Fhn39o3aDKPfVI r4jyM4OAzpL2vXX8TLKqBTTty6Qs4mbT8xmQAVDT8WLjAEKvng7uOaEfjvn0mH9D3zRF/h78i/uUK GaqhXeX5+biAd6vlaOtIoaxduq9G269WaYyjsb0XaLl3ud+cOKyH6sND8QNbjB/keNt0nDKThfXD9 BhpHl3fSMVKheH7S+PMDefg6DyrvkSDingnE6m/aCC84UZS4mhWRrTQlrToSj63JipLG3f9EWwI/B KNSVpQSHRxkaKVZt4MSuwUl5RKC8BJIBwlX5aBTaIVyFlfxJwtMU0Xg3UdhnqwcnXZwNHtdcINkA/ pOSGsVzE2/0PBn9Deh8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miuMf-00Apx4-H9; Fri, 05 Nov 2021 08:14:21 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miuMb-00Apua-JD for linux-arm-kernel@lists.infradead.org; Fri, 05 Nov 2021 08:14:19 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1miuMT-0006S3-00; Fri, 05 Nov 2021 09:14:09 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 7FDC5C292A; Fri, 5 Nov 2021 09:13:51 +0100 (CET) Date: Fri, 5 Nov 2021 09:13:51 +0100 From: Thomas Bogendoerfer To: Florian Fainelli Cc: Guenter Roeck , linux-kernel@lists.infradead.org, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Arnd Bergmann , Linus Walleij , open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] bus: brcmstb_gisb: Allow building as module Message-ID: <20211105081351.GA6380@alpha.franken.de> References: <20210924191035.1032106-1-f.fainelli@gmail.com> <20211105025155.GA2922689@roeck-us.net> <9318932a-9b00-62be-eeb9-ca755a05c841@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9318932a-9b00-62be-eeb9-ca755a05c841@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211105_011417_827470_9ECED662 X-CRM114-Status: GOOD ( 23.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 04, 2021 at 07:56:12PM -0700, Florian Fainelli wrote: > > > On 11/4/2021 7:51 PM, Guenter Roeck wrote: > > On Fri, Sep 24, 2021 at 12:10:34PM -0700, Florian Fainelli wrote: > > > Allow building the Broadcom STB GISB arbiter driver as a module, however > > > similar to interrupt controller drivers, don't allow its unbind/removal > > > since it is not quite prepared for that and we want it to catch bus > > > errors all the time. > > > > > > Signed-off-by: Florian Fainelli > > > > Hmm, did you actually test that ? > > Great way to introduce someone to a problem, really. > > > > > Building mips:allmodconfig ... failed > > -------------- > > Error log: > > :1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp] > > ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined! > > I did not indeed test a modular build for MIPS and had not anticipated it to > fail. Thomas, do you have any objections exporting board_be_handler to > modules or would you rather not do it and force the driver to be boolean for > MIPS? I'd prefer to not export it, so making the driver non-modular for MIPS would be a solution. If there is a need to set the bus error handling I'd like to see a function setting and that function could be exported. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel