From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2432C433F5 for ; Fri, 5 Nov 2021 15:03:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E80A60EBC for ; Fri, 5 Nov 2021 15:03:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E80A60EBC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tLvMhtGdvTRDh2n5jeYmWHPwsmUBz05U7292862hSA0=; b=qfPJnE6//poGkg jqZXq/njwEm5ShfA74KDIND73N1ZD7qLLFZTrQMJ2gnPQDW3ra/W4elkXjuo0+AWDV9Pgv6z7IGyk CcZV4fmxwYyeSPzuu1oBKJIWIHbyneip/E8P5vSMpzo3awBMVO9lOA+pKpmJZfhbfs0nvdeKBmvJv M7Ce6/icPK1NfK7p4mpUPd3URX6A2sT23EpsbQwHxghlpb48qIZ9R8GUmerJ71Pxfo1FPETnoVtaK UmAOaVXZh3qWp5MpTPhq5MWp+ZOJdmGlBEe9Qua/YdK9Hj8L2DX5qf8XwNqdQqMEiItwqKLDrcoPn xP4tjyX3Bt0mjDB8LB5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mj0jA-00Be9S-IL; Fri, 05 Nov 2021 15:02:01 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mj0j4-00Be7G-5R for linux-arm-kernel@lists.infradead.org; Fri, 05 Nov 2021 15:01:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HEBvWRg9S4l41qj5CuJ9xd8WUMjF45Gsh7boop/TI/8=; b=exjT7KNvOAVNQofMTz4xN+rh/+ rghIpP6ikdGyFT05k2paeUz32XPxNsFZP5Um9+H1tYYr8q6EeyW+i9y/gHZuursjvbc9L5qFvwj/4 dCTgxw8CD9KnvLvp0IUf5mCj+sAcNNGFtzOjYZrRzK8QLagQCyrl7DwGKNAI272patCA=; Received: from p200300ccff0899001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff08:9900:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mj0j2-0004v0-Kt; Fri, 05 Nov 2021 16:01:52 +0100 Date: Fri, 5 Nov 2021 16:01:51 +0100 From: Andreas Kemnade To: Alistair Francis Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, mylene.josserand@free-electrons.com, linus.walleij@linaro.org, rydberg@bitmath.org, dmitry.torokhov@gmail.com, robh+dt@kernel.org, alistair23@gmail.com, =?UTF-8?B?TXlsw6huZQ==?= Josserand , Maxime Ripard Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: <20211105160151.4d97d587@aktux> In-Reply-To: <20211103114830.62711-2-alistair@alistair23.me> References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-2-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211105_080154_414917_3995B7C8 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Nov 2021 21:48:27 +1000 Alistair Francis wrote: [...] > +static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq, > + const char *name) > +{ > + struct cyttsp5 *ts; > + struct cyttsp5_sysinfo *si; > + int rc = 0, i; > + > + ts = devm_kzalloc(dev, sizeof(*ts), GFP_KERNEL); > + if (!ts) > + return -ENOMEM; > + > + /* Initialize device info */ > + ts->regmap = regmap; > + ts->dev = dev; > + si = &ts->sysinfo; > + dev_set_drvdata(dev, ts); > + > + /* Initialize mutexes and spinlocks */ > + mutex_init(&ts->system_lock); > + > + /* Initialize wait queue */ > + init_waitqueue_head(&ts->wait_q); > + > + /* Power up the device */ > + ts->vdd = regulator_get(dev, "vdd"); > + if (IS_ERR(ts->vdd)) { > + rc = PTR_ERR(ts->vdd); > + dev_set_drvdata(dev, NULL); > + kfree(ts); > + return rc; > + } > + > + rc = regulator_enable(ts->vdd); > + if (rc) { > + regulator_put(ts->vdd); > + dev_set_drvdata(dev, NULL); > + kfree(ts); > + return rc; > + } > + > + /* Reset the gpio to be in a reset state */ > + ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); so we deassert reset for > + if (IS_ERR(ts->reset_gpio)) { > + rc = PTR_ERR(ts->reset_gpio); > + dev_err(dev, "Failed to request reset gpio, error %d\n", rc); > + return rc; > + } almost no time > + gpiod_set_value(ts->reset_gpio, 1); and then assert it, keeping the chip in reset > + > + /* Need a delay to have device up */ > + msleep(20); > + and why it should wake up? I reversed the logic here to test. I have reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; in my tests. > + rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq, > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > + name, ts); falling or level low (according to the example in the dt schema)? Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel