[PATCH] clocksource/arm_arch_timer: Fix bogus -Wsometimes-uninitialized warning

[Oliver Upton <oupton@google.com>]

Since commit 4775bc63f880 ("clocksource/arm_arch_timer: Add build-time
guards for unhandled register accesses"), clang builds emit the
following warning:

>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
                   default:
                   ^~~~~~~
   drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
           return val;
                  ^~~

which is of course meaningless, as we break the build if the default
case is ever taken in the switch statement. Clang does static analysis
before deciding if the branch is ever taken, leading to the warning.

Fix the bogus warning by initializing val on the default branch.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 4775bc63f880 ("clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses")
Signed-off-by: Oliver Upton <oupton@google.com>
---
Heh, I had caught this earlier but didn't hit send before starting the
weekend. Saw the bot email, so sending out.

 drivers/clocksource/arm_arch_timer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 9a04eacc4412..8e2814fcea11 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -172,6 +172,7 @@ u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
 			val = readl_relaxed(timer->base + CNTP_CTL);
 			break;
 		default:
+			val = 0;
 			BUILD_BUG();
 		}
 	} else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
@@ -181,6 +182,7 @@ u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
 			val = readl_relaxed(timer->base + CNTV_CTL);
 			break;
 		default:
+			val = 0;
 			BUILD_BUG();
 		}
 	} else {
-- 
2.34.0.rc0.344.g81b53c2807-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel