From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38DEEC433F5 for ; Mon, 8 Nov 2021 15:47:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 014546128B for ; Mon, 8 Nov 2021 15:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 014546128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5O4QudvRzijGLYfqacKQayBaSp6PdxKx0b3Pf2zH5BQ=; b=uP+L3PR8ICKFIO yBwfGE3Bi9PIZ/bP5m2pm23GT/9r4yimYW9ywIRGuvUS+OIODBjq6DubVsBShWVRWvt45YwnMAWbT iPTAfO3DvPOO5D08oi7rc4W2Tl3g/pDYaQTLeMrMnUhOa0L+3KeBKKCOspolJhXVcVXXGd0dvHiRN LGxvyruDo2x4hLIU+JL6onyodrBQ0PCUh9Vb1Z684p7FXO3nu6F91yZ6AmonHF/X8UnoiJmR4edGS XFwQq8fw7wxKteVSu5cxr2jrItKlKU3QxNnVDqQ8qA+6/XYkiSW3KNhYEUq7dg6zMSXnfiAn+QDRQ Hj4+IxoqtPGrbz5DDDSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk6qQ-00Gs21-Sx; Mon, 08 Nov 2021 15:46:03 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk6qN-00Gs0x-2V for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 15:46:00 +0000 Received: by mail-ed1-x52b.google.com with SMTP id m14so63607881edd.0 for ; Mon, 08 Nov 2021 07:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PVza8bc+buwzI929X8sHOlCTGiVgpXXZXYwI8Fybjx0=; b=phVki65L5hxv+xQOyJZrMNRFTbKH8OSIgDhhxuQwrxszhIsMEYK2tLOpFd6UvSQPhZ tzin2L3SCtV4nnTmGGJee1cW3YYxd2bTzWjqD9czUAc0h44JLEhAKGuwEmZB6EaBSfJo aZRUcsFCRMxgBKkmcuGfNo0wHG/5hbZG8j/GZ5Tae7vFKszVoaG7AF0a3LjEmzjYOhZ0 RYXNe9hex9CxKhRjDVTeUKxGdC5eJBSheHLCJWgEsbiPt9X4UqRvrzxeKDoDoGtHx53u STkv5P52gd9jJpYVeCz1rbzirDzJU4brHGIaFJT8ndihadb6Y6Bk5i8AK3cinOYPniap Y/Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PVza8bc+buwzI929X8sHOlCTGiVgpXXZXYwI8Fybjx0=; b=Z2CBY3VoZ9RDxa64ch5UgrNQXFXTnPkNpdjV5pLa2DHA+wSxRhIVU3+pajCX4T6FWk nOWZwMqQkbNHxitLXTlBWZ5QCbDs7d/8RzmeIvCO9qbXOlLL4yYZ/eSLvwtxVNfWHNzt lZEz2P6HXbBM+mxs4LAq0sw8jxDLcockSQ6M6eliwZCCd/g6PwSRBFASGj5jniALv4/P 1xthIM1vd/ablY5ObOriDkCVohbLZ2Uun/oTDzeQU5Ih/BmackUIyvVbwXrjluUb3c70 a25GFHDKINs7FGIydiVy/hjf8FkrJWxX2q2n0knwmnYNNmOD3f3jnJHZn659wIrm2qjN +Pzg== X-Gm-Message-State: AOAM531JfJv1pYq2N1QfUhVlsMv9C1AhPvI+detUXUum8UmlrDtYG4nk DlMbsfU0Jt58bpCFSHQAtu0= X-Google-Smtp-Source: ABdhPJwJmcAuxFWPTO6M9QJsOkA9H+B2EKW7FArIW5Jx9cV/hYP96PeZTzf5PPn+RN4BVA5Gqqtdvg== X-Received: by 2002:a17:907:3f18:: with SMTP id hq24mr302251ejc.506.1636386356512; Mon, 08 Nov 2021 07:45:56 -0800 (PST) Received: from skbuf ([188.25.175.102]) by smtp.gmail.com with ESMTPSA id f7sm9536865edl.33.2021.11.08.07.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 07:45:56 -0800 (PST) Date: Mon, 8 Nov 2021 17:45:54 +0200 From: Vladimir Oltean To: Ong Boon Leong Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Voon Weifeng Subject: Re: [PATCH net 1/1] net: stmmac: Fix VLAN filter delete timeout issue in Intel mGBE SGMII Message-ID: <20211108154554.axd2lmm2a3gw6vfu@skbuf> References: <20210305054930.7434-1-boon.leong.ong@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305054930.7434-1-boon.leong.ong@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_074559_150186_FB1C7795 X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 01:49:30PM +0800, Ong Boon Leong wrote: > For Intel mGbE controller, MAC VLAN filter delete operation will time-out > if serdes power-down sequence happened first during driver remove() with > below message. > > [82294.764958] intel-eth-pci 0000:00:1e.4 eth2: stmmac_dvr_remove: removing driver > [82294.778677] intel-eth-pci 0000:00:1e.4 eth2: Timeout accessing MAC_VLAN_Tag_Filter > [82294.779997] intel-eth-pci 0000:00:1e.4 eth2: failed to kill vid 0081/0 > [82294.947053] intel-eth-pci 0000:00:1d.2 eth1: stmmac_dvr_remove: removing driver > [82295.002091] intel-eth-pci 0000:00:1d.1 eth0: stmmac_dvr_remove: removing driver > > Therefore, we delay the serdes power-down to be after unregister_netdev() > which triggers the VLAN filter delete. > > Fixes: b9663b7ca6ff ("net: stmmac: Enable SERDES power up/down sequence") > Signed-off-by: Ong Boon Leong > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 0eba44e9c1f8..208cae344ffa 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -5249,13 +5249,16 @@ int stmmac_dvr_remove(struct device *dev) > netdev_info(priv->dev, "%s: removing driver", __func__); > > stmmac_stop_all_dma(priv); > + stmmac_mac_set(priv, priv->ioaddr, false); > + netif_carrier_off(ndev); > + unregister_netdev(ndev); > > + /* Serdes power down needs to happen after VLAN filter > + * is deleted that is triggered by unregister_netdev(). > + */ > if (priv->plat->serdes_powerdown) > priv->plat->serdes_powerdown(ndev, priv->plat->bsp_priv); > > - stmmac_mac_set(priv, priv->ioaddr, false); > - netif_carrier_off(ndev); > - unregister_netdev(ndev); > #ifdef CONFIG_DEBUG_FS > stmmac_exit_fs(ndev); > #endif > -- > 2.17.0 > Don't you also want to fix the probe path? stmmac_dvr_probe: ret = register_netdev(ndev); if (ret) { dev_err(priv->device, "%s: ERROR %i registering the device\n", __func__, ret); goto error_netdev_register; } if (priv->plat->serdes_powerup) { ret = priv->plat->serdes_powerup(ndev, priv->plat->bsp_priv); if (ret < 0) goto error_serdes_powerup; } Since the device can start being used immediately after registration, it depends upon the SERDES clock being powered up. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel