From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A21C433EF for ; Tue, 9 Nov 2021 01:28:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EC3561104 for ; Tue, 9 Nov 2021 01:28:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EC3561104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qRzXRfM70BmoJVgY7KevbPwGyA5PBeQ0iqoXZWNVKlk=; b=B9q2BlkeywYmwD qXjyZvRFzs2PCML/o1xI/NjYhkl3WtZ2YICPDqRAKuog3kx5JglE3HmluUbQ9BKkcm5DIe+pJ9yJp I3YAiUd8W0Q2RtXDkdrwWHB69eT9OaunZcRMfLDhmkqyFRoLp+hudRCJZuoQgJ9m1i8IuuCZMVvmS 5Q5XR9UN11jiIh4pxTY8d76FJVJuuLPvF+UpCONEOrnen4auYvgZ8MKUnAJ2aqcaIBXZ9k//aH8S8 AeoCPdTfNyKf6prlsRCP9371CkkX5M2CnUsjRrh3eFs4YBEVte9ep6ZYxH/r7Db3VHDQHLxF4/Ue/ tEClrKVvw7XXFMR0bS8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFuN-000KQi-Dw; Tue, 09 Nov 2021 01:26:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFa9-000CwY-0n for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:05:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3F26161A09; Tue, 9 Nov 2021 01:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419948; bh=vX3XEse8BNh+6SkQZ8/Qtrl79RAZXOZ0Sx1Lyy6b0Wc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uDsgX7L/30EqwdAXRhhneVY5P09ra/RRKObuQWIO2PTw4kKskG+Uwgxb6FeR0D4GN F1rDnCcl7qsFjdR80QxiU9cLkOCM54afwnQAE7LKNPqnWZTkHDDZvuxsn/QIVsRLad e7x6HKGhdORmHChQ5/65OFdfd5TuOzSwwagJFVQ9n1YJ1qxcocA5xBZ0Ppf+qqIEac 39q24qUZ+bY5BIuRrXy/nsYdpufXK5R+7vfsOCVAmLxEfLRZugtXIoGTVMPo6VIIUN XZQlZ/GzVk3+RQdOgrYIf7o62c5FEPqUw6B+Iv4xHHkTYrub92bEqbVunLyews4iZF 7Uj+ljEjumW7w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tuo Li , TOTE Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 18/47] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Mon, 8 Nov 2021 12:50:02 -0500 Message-Id: <20211108175031.1190422-18-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108175031.1190422-1-sashal@kernel.org> References: <20211108175031.1190422-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170549_138270_2AD5CFEE X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tuo Li [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error information. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 4b8516c35bc20..80bb58d31c3f6 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1276,7 +1276,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel