From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44522C433F5 for ; Tue, 9 Nov 2021 01:29:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1180D610A3 for ; Tue, 9 Nov 2021 01:29:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1180D610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0D7HIP4UbZ2hpdB+msr9wiMg4le/lXcw1d39qqxf4Bc=; b=zgKJfhjUhV/qpy ZswiQrGGCUL6FzDXPC6QFUyzFUbhTTdt4ZWUl1vHDlc4NZfB/Xch+rI+He0vc0TWJEMaleIsAHU1R h14NWf/mL984dekyq/6nUY/7UFzwInQg7Ve/GxwNFxGhKggP6Xwj3vS0J97j6RNoU2ZPAZLPBhlNq f7BnIm20JfniLIiOYU1P7CFwQMVJm0zfUvHqHc2yfKUr1VezdNNPI70q6ir3XDqPnLi86ef7y3LhZ 38o9G0S+6Z40ls/fzBhs1KBJWHB9MOKPZxiGQD2slyEr2a03lj2966DPvW/90tLAdHZDkZhlpFJsd 6n1LZVoAkpy0z++OXr6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFvO-000Kpq-SQ; Tue, 09 Nov 2021 01:27:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFaA-000CyD-7D for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:05:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDBD261ACF; Tue, 9 Nov 2021 01:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419949; bh=fGFQjNNUdNrz52vfi3x9I5L+GYEXW1Vh5yiXJ8d4EGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgZlGXOBfFkIqmXWXPG6A6G9XvF8fBIxQSvuV6Od8LQFny3dO+q2i+B5I0dFXs61L 6vrc80muSSGturxPE8J5oDGs/G5VHtyyhwK+gBYm+v2rrECXWkzqwwyL3d3JjtPfqy 4781L3N/iB06WbgDsd+n9FHlYDOik2DQPIjKcE2VjMjHlTltxCR7OlaxRo0vYD0IX0 /I5BPMUq8nM58bHcPHk6WBYaRBQYqETCwwtaYLA5UTmdESkg7FxSpmyN2M3yChDPiB JBAEaE95YGtb8nqA8vSKNRNtMXP7+aG1R6JDwWUT25XWhLTC1+qhIUSoUdHdbs8YyV kiTpA0Z++sHpA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nadezda Lutovinova , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 19/47] media: s5p-mfc: Add checking to s5p_mfc_probe(). Date: Mon, 8 Nov 2021 12:50:03 -0500 Message-Id: <20211108175031.1190422-19-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108175031.1190422-1-sashal@kernel.org> References: <20211108175031.1190422-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170550_293947_B57C27F5 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nadezda Lutovinova [ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ] If of_device_get_match_data() return NULL, then null pointer dereference occurs in s5p_mfc_init_pm(). The patch adds checking if dev->variant is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 80bb58d31c3f6..0fc101bc58d67 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1281,6 +1281,10 @@ static int s5p_mfc_probe(struct platform_device *pdev) } dev->variant = of_device_get_match_data(&pdev->dev); + if (!dev->variant) { + dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n"); + return -ENOENT; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->regs_base = devm_ioremap_resource(&pdev->dev, res); -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel