From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22EBC433EF for ; Tue, 9 Nov 2021 03:25:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 709FB6128B for ; Tue, 9 Nov 2021 03:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 709FB6128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=j7hP09IOsDgHB5J/wsOzNPb+TW2fVxqj+I9U+3to/CU=; b=TqM2Lf361qxmB4 XcGzrmDPe8XAM8HqAYzls3/oqHbHwAgC9+CL09fxZubWi9hmAjL8INquTfD30vIlnBDP27wZ3kCWh /XYEYP226UpuFuZZro6DJtobTEAy82WTDaFObksGesA7Mv9uPTA7c7G7wN3MQhGz9vi8OLKw14jEu Biqc0HjQaT0sWEqa4Aae3O2ISc6JeHYjRxKiqVcHEQuayxtGHD+L4S1zTOtMcL6/iPM2FqGxltHo0 IU/Md2NClI0c1UyyKTbyf+UjjBLxZ7PO210D7zc37sYS35u3NxFNl57Luq/M64tGEg0l5OoKH8nxo HIZ4rBrq40piXTc+0h0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkHjs-000aru-2C; Tue, 09 Nov 2021 03:24:00 +0000 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkHjn-000aqp-VD for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 03:23:57 +0000 Received: by mail-qv1-xf2f.google.com with SMTP id v2so13327874qve.11 for ; Mon, 08 Nov 2021 19:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2V3HogjR6tzeLasoYLzy6we6u4i3vWdwDzTcRieWiEM=; b=LKmalwKErazJJMZDAs8oZwXA/te5qGZYGXTxMEHcmVJf+XS9M8wT0fh3k0hmf/XDZ0 yi6id+IP38VRYUwbGNeq4MlUgDwU6N9MtCw1q1yYh3c6N0FV1jJbo4WOxtjzaZtrryUS NFWk0a96iyu6mjMc260jlsndn+BUXvcJjLP5KXc1Nl0vksgTp8IIAEQ4GuzXrRJ8+Hi5 SM021kwP48z1A77N3qqpuKy2P0XXTXHnFSTvBr8VmJ/Jt7CClHTX47WUh1yw15J51bu+ 9NHvn3fWf/R0o/blQpqIr2amky3axROrIpPPoeDiU+gOAQXGZhygjP9eTO9tFM20Lcjx ZPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=2V3HogjR6tzeLasoYLzy6we6u4i3vWdwDzTcRieWiEM=; b=NfHqvEDPnrMOvMh/nTPnDoWaUCozF/B0CCdI8a9yA3HE41CMBQwpXwl0IkIk3EDkgy 7Hg92VZ5vWcBrPPQ9HNb7AO3dcnxS1+GM35Ma2MUFju6xbVfMANA5EWO51QHfv26TAUy SMX+TCgDxdrsLDbf3SghodSYMd1BA4e2zvq+owOC8z29xlivk5P+FXb/n11EPziyMnoE PkHWfjjSxq9JVEMqEExGci9YXCc5cXCuHEjeg8VyNCb2ueaFy3UAUlt6cXZOjUvOVbWm 3iNPhO2hkbdlqcmMfzcVbbB4yPWyovBZr9Tmoijo3hmzcWFoKwS4Ap4qAKUaJXiBEhdp 1nQw== X-Gm-Message-State: AOAM530IaaV6PLMxsqmSfs4s4zU8BMy0QniS/LDhFXp7p/dxGvhjpnd6 LjTiFbxB/LyCQJdxu26U3OQ= X-Google-Smtp-Source: ABdhPJx/A45jDBxyjJp26aQ17KId/KksS/DEix+3w66MMwl/WrSdu8dJIgKKzsVCzb8Z0GoWSqPLkg== X-Received: by 2002:a05:6214:411d:: with SMTP id kc29mr4253736qvb.22.1636428233263; Mon, 08 Nov 2021 19:23:53 -0800 (PST) Received: from localhost.localdomain ([67.8.38.84]) by smtp.gmail.com with ESMTPSA id f7sm11032327qkp.107.2021.11.08.19.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 19:23:52 -0800 (PST) From: Julian Braha To: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com, wens@csie.org, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: [PATCH] [PATCH v2] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Date: Mon, 8 Nov 2021 22:23:51 -0500 Message-Id: <20211109032351.43322-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_192356_052560_993EDAE3 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=n] Selected by [y]: - DRM_SUN6I_DSI [=y] && HAS_IOMEM [=y] && DRM_SUN4I [=y] This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY without selecting or depending on RESET_CONTROLLER, despite PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. v2: Fixed indentation to match the rest of the file. Signed-off-by: Julian Braha --- drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 5755f0432e77..8c796de53222 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI default MACH_SUN8I select CRC_CCITT select DRM_MIPI_DSI + select RESET_CONTROLLER select PHY_SUN6I_MIPI_DPHY help Choose this option if you want have an Allwinner SoC with -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel