From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A066C433F5 for ; Tue, 9 Nov 2021 17:42:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D9916105A for ; Tue, 9 Nov 2021 17:42:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D9916105A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gqs1FL+mfbH2YHdmWujtH0Yny+Yq9+qEnqucTSYzI64=; b=HIVrRFpGzbgMCK mXGRZQjBTDwbAzdiwy840Hq0bITbFXxiD5JxLDOWcvvozRnnoOpsSLuUKc86VnX0QhNcEeVUoxt84 XVe17O26BgDuiDFSu97lW9UZif8ZBOsHHWob0MR5ypX2vG290NXHjfgqAY7KWHvcXzRAm5+In4x9q DggJZSwg2XjFPFfte6fr/TO9pzY7SQ+2sts+UqXsDafGV7tupAeB/pPMtoJuQ+rS022VTzQ64aFyt 4FEjKl6Dunk6TsfHH+DSoHTY/0qknUfDo3kjhsR1UdSDAA4dnkIl2UEgEIBgpmv0R2xHanHlILrNx AvnmDPX/ityh4IVs3HqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkV79-002uMU-13; Tue, 09 Nov 2021 17:40:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkV75-002uLj-2O for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 17:40:52 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C7BC61208; Tue, 9 Nov 2021 17:40:49 +0000 (UTC) Date: Tue, 9 Nov 2021 12:40:46 -0500 From: Steven Rostedt To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , , Marc Zyngier , , , , , , , , Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event tracing Message-ID: <20211109124046.2a772bcb@gandalf.local.home> In-Reply-To: <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> References: <3706af20bc64a320ff8f3ff8950738b988f4bdf5.1636452784.git.quic_saipraka@quicinc.com> <20211109104941.2d50eafc@gandalf.local.home> <20211109115951.1c2b5228@gandalf.local.home> <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_094051_158591_FD53B7A9 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 9 Nov 2021 23:00:11 +0530 Sai Prakash Ranjan wrote: > Ah that's a very good idea, descriptor does contain the module, file name. > We can probably even pass the module name,file name as string from the > descriptor itself to event? > Perhaps we can do that for all trace events and not just this trace > event? Just like the trace event name displayed > with trace events, perhaps have file name,module name displayed when > dynamic debug is enabled? Filtering by > filename is pretty useful since most of these usecases in debugging will > be with respect to some driver or subsystems. If we add this for all events, it would require a lot of changes to all users of tracepoints, as it would require adding a new parameter to the callbacks. We could add a flag in the registering that states that the callback is OK for it, and it passes that data as well. Let me look into this for a bit. I may not have something this week, but we should look into this more before adding little hacks that do this one at a time like this patch. -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel