From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBAFCC433F5 for ; Tue, 9 Nov 2021 21:52:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF14961131 for ; Tue, 9 Nov 2021 21:52:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF14961131 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6e6PxHL4NNnrvXPsmDRGslTFKDUqm5vzu1JJLF8xilo=; b=Ep7beENHfvrx93 YGnTc7errS+cSYlSpWemq1wN9lhRb2RQ0D+PmcparbPpnXflqPB6wMgSDteqlKk/vl9+YLRJMjiXK vgY++38WetAkP9kztu43FSGbNBanenrBoMicDUl9pucRyOK/rq9cAVltY4O9cS5zRWLZCtwpdL86o bK0x0hYZ8/aqsVzHZekbIqZhmjDQYxd+4SzOyTPWgVG3ylSjAY9CEO3jU2wXUSjzQf8ejvZFCcLbC unwlW2W1qw07a+vOLHkaZ36Tq64tiRudbFH7kfLwOE7QjDbojqQAcJjixBpBgTpf2Ib0JhyEYX52O MDwgHUVsmdB5RoEogbyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkZ1M-003IpD-8V; Tue, 09 Nov 2021 21:51:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkZ1I-003IoW-8x for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 21:51:09 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C5B361178; Tue, 9 Nov 2021 21:51:06 +0000 (UTC) Date: Tue, 9 Nov 2021 16:51:04 -0500 From: Steven Rostedt To: Jason Baron Cc: Sai Prakash Ranjan , Will Deacon , Catalin Marinas , quic_psodagud@quicinc.com, Marc Zyngier , gregkh@linuxfoundation.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com, seanpaul@chromium.org Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event tracing Message-ID: <20211109165104.176b4cf9@gandalf.local.home> In-Reply-To: References: <3706af20bc64a320ff8f3ff8950738b988f4bdf5.1636452784.git.quic_saipraka@quicinc.com> <20211109104941.2d50eafc@gandalf.local.home> <20211109115951.1c2b5228@gandalf.local.home> <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> <20211109124046.2a772bcb@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_135108_371274_89951EAA X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 9 Nov 2021 16:42:48 -0500 Jason Baron wrote: > Yeah there is a 'parallel' thread about adding the tracing ring buffer as > a 'back end' to the dynamic debug stuff over here: > https://lore.kernel.org/lkml/20211105192637.2370737-9-jim.cromie@gmail.com/ As the maintainer of tracefs, why am I not Cc'd on that thread :-( I'll have to look at that thread later (no time now). > > The attempt there is more generic but I realize now that it is adding the > tracing to an 'instance' which is specific to dynamic debug which is > being created via: trace_array_get_by_name(). I would prefer to just have > it print to the 'main' trace buffer such that it's easier to read, > although I guess they could still be consolidated via timestamps. > Hmmm...I think there was a previous proposal to just add a single > tracepoint (that takes a string) to the dynamic debug layer that could be > called if a dynamic debug site is enabled for trace buffer output. Would > that satisfy the ftrace level filtering requirements that you are looking > for? What we are looking at there is to pass the dynamic debug descriptor to the trace event filtering logic, where you could filter on information passed to it. For example, on a specific file if a trace event is called by several different files or modules. -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel