From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A34DC433F5 for ; Wed, 10 Nov 2021 17:38:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64951611C9 for ; Wed, 10 Nov 2021 17:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64951611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S3CHQykN0JCPTeoH8fjK59IGgsMwkBvBWdBJVYhVojA=; b=qvr4SG+n4wMW/5 7RqNiyOYEHHPjHEckx54MUeQ1b5pw+zpzxfOcWo3YbemTzQrxkD6Qgphi3VocQZV6NLeUwg1smqZA GYa5hhzhTuCn7KoqtsDO50iCc4xySu5tz0xVu5X0ajFMfEyeED+gHJFIWdfL4H6m1soQxsK2T0Ybr bNQscAQQfMVv/TFJ1h5ALCI3dGR/33vSi2dp3TEuyNmmuJJtowU3U08vWSEphjcYrOxxLAfxDFnGI OQzhqo1Cua9uZLGYZZqQKa1GvYbRYMFByf92OB+GTyZV3k192aU/UsdXK9Cw8HiTjE0Vehh4k62vf N9pAfChmguXtoL8W60KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkrX8-005tyO-5b; Wed, 10 Nov 2021 17:37:14 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkrX4-005txk-3B for linux-arm-kernel@lists.infradead.org; Wed, 10 Nov 2021 17:37:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KlxesLbWPDNXnoH7U/Oi4/4ZNt/bBTzHwkDgmf86Hwg=; b=k5h77rlfxFgN394lib723UsbiC gZdAW788aWrEruU9eYofr8azJIOH7uxyusGDBb82Sn+8fDjquCMkwsKwSEXXcVz3lpNaeXGQwzeTe 93DeqK1pdqmdL6u3ZslsioXuEC66aqiavxLejWlufrfrjgtZ6YsjiEh2kLuLsZklJ05s=; Received: from [77.247.85.102] (helo=localhost) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mkrWy-0000B7-GL; Wed, 10 Nov 2021 18:37:04 +0100 Received: from [::1] (helo=localhost) by eeepc with esmtp (Exim 4.92) (envelope-from ) id 1mkrWp-00043U-7S; Wed, 10 Nov 2021 18:36:55 +0100 Date: Wed, 10 Nov 2021 18:36:54 +0100 From: Andreas Kemnade To: Alistair Francis Cc: Alistair Francis , linux-arm-kernel , devicetree , linux-input , Linux Kernel Mailing List , Mylene Josserand , Linus Walleij , Henrik Rydberg , Dmitry Torokhov , Rob Herring Subject: Re: [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Message-ID: <20211110183654.61328998@kemnade.info> In-Reply-To: References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-3-alistair@alistair23.me> <20211105152154.20f5cbd1@aktux> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_093710_343436_FA1D8BB1 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 10 Nov 2021 22:59:50 +1000 Alistair Francis wrote: [...] > > > > > + reset-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; > > > > hmm, if the reset gpio at the chip is active low (I guess it is) that > > would indicate an inverter between SoC and gpio. So a nonstandard setup > > as an example, probably not a good idea. > > It seems to be common for the cypress,tt2100, as the original > documentation and the rM2 both do this. Does the Kobo not do this? > You have a kind of double inversion here, so things are automagically fixed. IMHO to describe it correctly would be to set GPIO_ACTIVE_LOW here and in the driver /* Reset the gpio to be in a reset state */ ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ts->reset_gpio)) { rc = PTR_ERR(ts->reset_gpio); dev_err(dev, "Failed to request reset gpio, error %d\n", rc); return rc; } gpiod_set_value(ts->reset_gpio, 0); That is the way how other active-low reset lines are handled. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel