From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4911FC433EF for ; Thu, 11 Nov 2021 07:19:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10F7261107 for ; Thu, 11 Nov 2021 07:19:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10F7261107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qOv8Dm2r9mZybBJ5n5IVGWapNB7fTDDphA6PVaWdtns=; b=2YUPsaR1jcaahJ I6SJiDrvl9uikhkgi45STv0Gic2Y84o1aXq00HWAfBJfS1TOJ9KkZMb7xKv+5WIm7Zbb1tvcuzv2i +W7pZMhYmYfYKkqXkNjPoB5T0tfXv4SidaGDSsrPqqZgbVAxYFO4pe6x185KQHSpNeAbIdbao8IM+ z7jZ8gO9eKKV0r7YR9au7B4ozgEcSAzTb+cDxPm4elfoRbsXDYCutj7ws6LuaYhK4ofI9oFd3vtIQ Huz9ZhAi0pGx7+VDRbP5jn7bvfJBWzSmxvSTyUNqD/dXa6fZsZSXYNSznJV780Jxo1POHMKBt38r5 /fw3AH/wuRCSf2MujF3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ml4Lw-007MVp-F0; Thu, 11 Nov 2021 07:18:32 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ml4Lr-007MTy-6B for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 07:18:29 +0000 Received: by mail-pl1-x633.google.com with SMTP id n8so5083991plf.4 for ; Wed, 10 Nov 2021 23:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PYrvbXawX/D86nhUYmoX07v/ep6S8FSDyEh1vsVQ5lA=; b=nBaUZWPAK0PuqPJ946GqOziDlcGX017pnlnYd7tQi7u36QwyYhUNmU78WEgB/Bwh8z lquVB+f2q2T6ei+5VFL9vGKhkUKLjv1FdfSuSH4CIy76Rwbi9p62GXC3iT2x+BCPpclQ aTrKoP+LsHRj1uOeFh/FiRAm7BluCU7MPJRn4JIkLzziU/Go1KD1FeGVHIwMA05zPdAm QtV6j2LswVZ48UQtJmU2NrD8ibnX1Ox673WVu/IteTsYHBj+zF4hEUplqzPZ7kV8GI2D grY7eaHTS4enzY7pRi8pDgSq1VmIIriOYWT0ldtnM686k0U1DRmgne90k3b7DJgcQ1BJ +p2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PYrvbXawX/D86nhUYmoX07v/ep6S8FSDyEh1vsVQ5lA=; b=oVkuAgtwqBEPjsZ71SJL4nMqxdnPJfhhZ4AMo9DzsVLahQu0/TWSnVE1g/TKr/8Xl4 rtfbi8TVIymBjqaSphPOy6TYGuGwLwfmYYaudu9uziBqN/uK84x+pyRXxweTndViK5TB fAhLZRd4jm/3XgGuY4nLz0ilTp9jUFeTqRyzLweZxb0H5zgu6K1hc2oaHAeU2SD83LDG fowuqbGg666Vt7i7vViSW0xMnEDSMb1en8JObefZOMwfooDny0TzwwDQuBQfxd8lkXJa v82Q8MEuf3lFZEzO4j13y+4sXs55WTU2OynGe2XhTTduCYVJ/woGT8km3yYbhvdjVSEY vmEg== X-Gm-Message-State: AOAM530g1dPhCnLMNkXuLGRalYOphmPXTQd8gG3qxP+InBdxaQZYkoFg aB2uy8f0GECTBoumvLQDnRMkaQ== X-Google-Smtp-Source: ABdhPJydPbEjUiXMik5uIU53Rj70Ky1Wu38t2u0Q19XKvOMobEIbSXRkxrgmnL6ASFs/LxSavtIGbw== X-Received: by 2002:a17:90b:4a4d:: with SMTP id lb13mr23719780pjb.97.1636615101877; Wed, 10 Nov 2021 23:18:21 -0800 (PST) Received: from leoy-ThinkPad-X240s ([148.163.172.147]) by smtp.gmail.com with ESMTPSA id h6sm1865485pfi.174.2021.11.10.23.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 23:18:21 -0800 (PST) Date: Thu, 11 Nov 2021 15:18:15 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , Mathieu Poirier , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] perf arm-spe: Update --switch-events docs in perf-record Message-ID: <20211111071815.GA102075@leoy-ThinkPad-X240s> References: <20211109115020.31623-1-german.gomez@arm.com> <20211109115020.31623-3-german.gomez@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211109115020.31623-3-german.gomez@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_231827_289144_E9D7D20E X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 09, 2021 at 11:50:18AM +0000, German Gomez wrote: > Update perf-record docs and Arm SPE recording options so that they are > consistent. This includes supporting the --no-switch-events flag in Arm > SPE as well. > > Signed-off-by: German Gomez Reviewed-by: Leo Yan > --- > tools/perf/Documentation/perf-record.txt | 2 +- > tools/perf/arch/arm64/util/arm-spe.c | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt > index 2d7df8703..3cf7bac67 100644 > --- a/tools/perf/Documentation/perf-record.txt > +++ b/tools/perf/Documentation/perf-record.txt > @@ -469,7 +469,7 @@ This option sets the time out limit. The default value is 500 ms. > > --switch-events:: > Record context switch events i.e. events of type PERF_RECORD_SWITCH or > -PERF_RECORD_SWITCH_CPU_WIDE. In some cases (e.g. Intel PT or CoreSight) > +PERF_RECORD_SWITCH_CPU_WIDE. In some cases (e.g. Intel PT, CoreSight or Arm SPE) > switch events will be enabled automatically, which can be suppressed by > by the option --no-switch-events. > > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c > index 58ba8d15c..725a06cd2 100644 > --- a/tools/perf/arch/arm64/util/arm-spe.c > +++ b/tools/perf/arch/arm64/util/arm-spe.c > @@ -169,8 +169,10 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > if (!perf_cpu_map__empty(cpus)) { > evsel__set_sample_bit(tracking_evsel, TIME); > evsel__set_sample_bit(tracking_evsel, CPU); > + > /* also track task context switch */ > - tracking_evsel->core.attr.context_switch = 1; > + if (!record_opts__no_switch_events(opts)) > + tracking_evsel->core.attr.context_switch = 1; > } > > return 0; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel