From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E4CC433EF for ; Thu, 11 Nov 2021 17:36:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 113D561390 for ; Thu, 11 Nov 2021 17:36:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 113D561390 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PPMGsE/N6MkY7cCjfTq2DsHvfqi1SCDnSoweplt3d8w=; b=PrjEltVf+5CLns 1a1mycE3okvZRZRho1kqLjOH09Aq4aJ0pkwMDn0al2YNQ5DZ7ORg+wEtklVdHc/P0g0Y/wgftL5JL GtRB1xTmwKp7HReA/Mynu9z07oDpR7X0eOUMzV8+RdS7lj9CWJz74oJ6VHDAtRi73kC9k4e3y/V+b HX4YNcbbysLokDmTF98PTtb+TsGvsmh2fSx8apFZ42HlaXMCnMmAYxL62rk7he4aCZsFY31PaqLd9 gq4z75FRVoy87UADKny7YB+p8oMZXvA/sLNi6zdfvX9MSNC1kxRnr8x+DVt7R7cIks2iG9x7usDM9 iNe0PZkNtj6OTDUZSO5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlDz1-008VEV-US; Thu, 11 Nov 2021 17:35:32 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlDyy-008VDw-A5 for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 17:35:29 +0000 Received: by mail-pj1-x102f.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so5337235pjb.1 for ; Thu, 11 Nov 2021 09:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+PTDg+RTmMmBtCf6xOlC59LUBnyq9/UGaw3BxnDuV2Q=; b=O2rkKt+aewbUqasmcmWU/JHyZVPuvq/KzbafxQdZo7VPwDhbnj/9UZiFJFSgkPPJ2m FDSaGPPKgH79bQhe7GwdvDVAmt8mmy7UeWeNmyNKgh3FhzjUwXyNPVwwDBTIkDSKj2jp sasbEZzFGSAbPCCeZROMd17d9MZ/KDuDsVv4YHJioFP/1oDu7k+r6XBNCSs01IfPf/7y h2uMRQHsr5R/FkzyHRKTs8Q57sEvYV1e2fYNoCL4K3p9wSm+Axe6g3EVz03czdZM0OaC YgvIyRa7BZUjvLkZNWe6Ev0xxGvnYt9roYwPiuNmDmdhV2QgLuw93zFy2cZVslV0Mgw1 H0iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+PTDg+RTmMmBtCf6xOlC59LUBnyq9/UGaw3BxnDuV2Q=; b=5HWchiVQCUolLMWkBDsjPC9iplQ1/XCVxuo+IxHXTbe+37UekbbQOoTlk8b/qqViFE pxTEqcTUtad9GF0+TQtz/ivMrh6wvVudAtE80YBkSQxXUh/EZ/nD189UxMTm/xwQGumk TN4PNqG/EerbmJwfW+RDmq3cInRNhYpPdTozVUJhPfEtIHyXnJgckZBoj2ZHWu1kh6NG xFXcWKPEsFa+NSZ3pk+98f2lK5DGEYKespoR4fagF7xq5zPa33JuFPrjDQ4vStWpPZ3V HjQeySL7LEFvSQUxc3ExqTf/XyGPRjDUgh0Sd6YS9xKfIdyJ0LUUlvGkD+Ohstn8zdg2 81/w== X-Gm-Message-State: AOAM531nmSUwncY96HgslVI8jO8B3PJRJ7ah8WOQT7SAiUn6uUfNBpzs PIC1JtSpElKhxqamyxJY+Pq4zA== X-Google-Smtp-Source: ABdhPJyGKlF4PmyGRmk25vsNL6MgoCeJtM6vG4ua1jdpvVlGvRl5rtHP8zWrtxoT/Fb9T7iF290j8w== X-Received: by 2002:a17:90b:180b:: with SMTP id lw11mr28999274pjb.108.1636652124557; Thu, 11 Nov 2021 09:35:24 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id a13sm4009773pfv.99.2021.11.11.09.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 09:35:23 -0800 (PST) Date: Thu, 11 Nov 2021 10:35:21 -0700 From: Mathieu Poirier To: Mike Leach Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, leo.yan@linaro.org Subject: Re: [PATCH v2 0/5] coresight: syscfg: dynamic load Message-ID: <20211111173521.GB2123533@p14s> References: <20211019191351.10242-1-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211019191351.10242-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_093528_412138_BEF5350D X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 19, 2021 at 08:13:46PM +0100, Mike Leach wrote: > 1) API updated to allow dynamic load and unload of configurations and > features. Dependency management between loaded sets is added. > > 2) New configuration and feature sets can be added using a loadable module. > An example in /samples/coresight is provided to demonstrate this. > > 3) configfs can be used to activate a configuration which will then be used > when controlling tracing using sysfs. > > Applies and tested on coresight/next - which is 5.15-rc1 I am done reviewing this set. Other than the minor comments for patches 1 and 4 I think it is ready. I would like to merge this set before reviewing the rest of your work [1]. Thanks, Mathieu [1]. "coresight: syscfg: Extend configfs for config load" > > > Changes since v1: > > a) Original set split to divide related changes into smaller sets. > Removed RFC flag. > > b) Revised config activation for sysfs to simplify common function. > (patch 4). > > c) Minor changes requested by Mathieu added. > > Mike Leach (5): > coresight: syscfg: Update API to allow dynamic load and unload > coresight: syscfg: Update load API for config loadable modules > coresight: syscfg: Example CoreSight configuration loadable module > coresight: configfs: Allow configfs to activate configuration > Documentation: coresight: Update coresight configuration docs > > .../trace/coresight/coresight-config.rst | 19 ++ > MAINTAINERS | 1 + > .../coresight/coresight-cfg-preload.c | 9 +- > .../hwtracing/coresight/coresight-config.h | 9 +- > .../coresight/coresight-etm4x-core.c | 11 +- > .../coresight/coresight-syscfg-configfs.c | 87 +++++ > .../coresight/coresight-syscfg-configfs.h | 4 + > .../hwtracing/coresight/coresight-syscfg.c | 315 ++++++++++++++++-- > .../hwtracing/coresight/coresight-syscfg.h | 39 ++- > samples/Kconfig | 9 + > samples/Makefile | 1 + > samples/coresight/Makefile | 4 + > samples/coresight/coresight-cfg-sample.c | 73 ++++ > 13 files changed, 546 insertions(+), 35 deletions(-) > create mode 100644 samples/coresight/Makefile > create mode 100644 samples/coresight/coresight-cfg-sample.c > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel