From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D3ADC433F5 for ; Thu, 11 Nov 2021 21:58:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD63261452 for ; Thu, 11 Nov 2021 21:58:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD63261452 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Tdh/zfpI3I7YfCdeBeVzioadVvTXZECiQPKBL57OUxI=; b=gPXLlrIYrwfRBW JE2pQSKcMd7EiiqeelwpMj++o4aVMNgy7V3xYH8q/o/OaNoE+15LnuBR8OEajMbpBmjNo7tBWVS4o h5ymwRWUeyl1kzZfrKUaepXKdY2wQfa3IfQcVXZxojOajLK2sOKyvRlWpBJhbCJ2aQBWNImKMEzSG mB0e9BtEdV20Bi9bsK0Q1DTJ88Tv91lqWz3R8a8e9Tg+PDzHTvcBiXbDu2lOoxVr6oK/f59qfHRxc m/Ldbo0O9rj4Y0maNtF/FJ9201azicr5DHcbB3ZVmmaqlIEU4fzGzzWAPd2aH7gjA98hbnvB2zpks x1OlPWubcHTm3wbMLxTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlI4T-008p3Q-Ni; Thu, 11 Nov 2021 21:57:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlI4O-008p2Q-UZ; Thu, 11 Nov 2021 21:57:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4880261252; Thu, 11 Nov 2021 21:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636667840; bh=ticax1p1bJ7oVmYMeKFcEh+6vye+SfczkbikmorTPkM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=q1eZA77xr96iZ+RsxYzDxqMYvzLNdL0DtUZE1GbbuCdnAWdfN5LkrEcgFKRIekTqC bn16QeJN8A1zo3JWq6Z/nH0GFeuSedeYjjxK01OTwMU/X5fo9IONrW37ccTcLnZYg0 5GRvLoovJnlOXcymAFj4m0wDTy1h441zsmmAWQrhQcSX07hLmKVOfGdC+mCPZZZ6yJ id2OC09/wiW3WMdfxPs+YrVP3KVWoCl8pXrorw4evj/z8fXb2qJdNsvpKRY5DwX6I2 ISAeHsp4x24o1l/MTA3Cylm3jfNiV35Vxq8l4ex/hfnGXjXsdPcLRuk4HKTcMMG2CS WPd+/7fC+n0XA== Date: Thu, 11 Nov 2021 15:57:18 -0600 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v8 1/8] PCI: brcmstb: Change brcm_phy_stop() to return void Message-ID: <20211111215718.GA1353371@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211110221456.11977-2-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_135721_042812_8FAD51CD X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 10, 2021 at 05:14:41PM -0500, Jim Quinlan wrote: > We do not use the result of this function so make it void. I don't get it. Can you expand on this? brcm_phy_cntl() can return -EIO, which means brcm_phy_stop() can return -EIO, which means brcm_pcie_suspend can return -EIO. brcm_pcie_suspend() is the dev_pm_ops.suspend() method. So are you saying we never use the result of dev_pm_ops.suspend()? > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index cc30215f5a43..ff7d0d291531 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -1111,9 +1111,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie) > return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0; > } > > -static inline int brcm_phy_stop(struct brcm_pcie *pcie) > +static inline void brcm_phy_stop(struct brcm_pcie *pcie) > { > - return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0; > + if (pcie->rescal) > + brcm_phy_cntl(pcie, 0); > } > > static void brcm_pcie_turn_off(struct brcm_pcie *pcie) > @@ -1143,14 +1144,13 @@ static void brcm_pcie_turn_off(struct brcm_pcie *pcie) > static int brcm_pcie_suspend(struct device *dev) > { > struct brcm_pcie *pcie = dev_get_drvdata(dev); > - int ret; > > brcm_pcie_turn_off(pcie); > - ret = brcm_phy_stop(pcie); > + brcm_phy_stop(pcie); > reset_control_rearm(pcie->rescal); > clk_disable_unprepare(pcie->clk); > > - return ret; > + return 0; > } > > static int brcm_pcie_resume(struct device *dev) > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel