From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E40C433EF for ; Fri, 12 Nov 2021 09:12:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8C6E608FB for ; Fri, 12 Nov 2021 09:12:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D8C6E608FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xE6zv6GQ8AeNsKRJFfS/HdjkLtUC38TMQGuiuPJyY3c=; b=kS2EYcy1m+fOfD z/8FVLN+eZPhyV9ESj+SylinnxegSSyM6kRBJc0Dt1M9jikRxAArSmDmtIJOI244dM9rOrJxRjVq6 2hvqIeQPGssd+D7rVGOgDSVaRlCD9NZWpffjTCI3HAceI/UQpRQ/cpW8D9kUo/4WpY62nbefFSVtN FUahQt7p+AJ72VW1AoTPAyar+qXuYp6DFC4o9gU5ZK7AtYzacAbck7wkDTl1dcUwVvN4Z0mOvJpzN KaUNt7aQvqooUBIa/DSRyKyErOC9sXJN4eG8xl3GLs3DW4F6jKDnrVjus/yoT0DL85N19xXqX0/MJ hyO4/KXSRgpxDUDSNySA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlSaA-009p5m-2j; Fri, 12 Nov 2021 09:10:50 +0000 Received: from alexa-out.qualcomm.com ([129.46.98.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlSa6-009p5Q-UB for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 09:10:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1636708247; x=1668244247; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nBm8KL50rPBclGGcQhaFKFJmx/7KYwhmoc+YLXPGjzI=; b=LhvTZQrpAPZi3Ic/6OB2Qkw8VQaGySohel7uQ/bnqiR9Mv3zRhftUzME SZ8abzFchK5/8XN2B5QICogbU3L75h4JWmThnvmhcQttWMs3/9YR4zZIQ wi+b6UGDQCfNTAB2AvaqPZD4aeIYauqujJerVNdVtS3U50hCzM0D6ntqm g=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 12 Nov 2021 01:10:46 -0800 X-QCInternal: smtphost Received: from nalasex01a.na.qualcomm.com ([10.47.209.196]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 01:10:45 -0800 Received: from jinlmao-gv.ap.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Fri, 12 Nov 2021 01:10:42 -0800 Date: Fri, 12 Nov 2021 17:10:38 +0800 From: Jinlong To: Mathieu Poirier CC: Tao Zhang , Suzuki K Poulose , Alexander Shishkin , Mike Leach , "Leo Yan" , Greg Kroah-Hartman , , , , Tingwei Zhang , Yuanfang Zhang , Trilok Soni Subject: Re: [PATCH 05/10] Coresight: Add interface for TPDM BC subunit Message-ID: <20211112091034.GA28079@jinlmao-gv.ap.qualcomm.com> References: <1634801936-15080-1-git-send-email-quic_taozha@quicinc.com> <1634801936-15080-6-git-send-email-quic_taozha@quicinc.com> <20211104180106.GD491267@p14s> <20211105082625.GE25738@jinlmao-gv.ap.qualcomm.com> <20211112084228.GA24524@jinlmao-gv.ap.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211112084228.GA24524@jinlmao-gv.ap.qualcomm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211112_011047_077679_D2B0F382 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 12, 2021 at 04:42:31PM +0800, Jinlong wrote: > [....] > > > > &tpdm_attr_grp, > > > > + &tpdm_bc_attr_grp, > > > > > > It is quite tedious to review all these options at the same time as the core > > > drivers. I suggest to concentrate on the base functionality for now. When that > > > is merged we can add configuration options such as these. > > > > > > I am out of time for this patchset and as such will not review the remaining > > > patches - those will have to wait for another iteration. > > > > > > Thanks, > > > Mathieu > > > > > > Thank your for all the comments. > > We will update the patches. > > > > Thanks > > Jinlong Mao > > > Correct the typo. Hi Mathieu, We will reduce the code changes. There will be code changes below for next version: 1. coresight: add support to enable more coresight paths 2. Basic function for TPDM(only enable/disable functions) 3. TPDA driver Is that ok for you ? > > > > > > > > NULL, > > > > }; > > > > > > > > -- > > > > 2.17.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel