From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55C2C433F5 for ; Fri, 12 Nov 2021 16:38:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8C8F601FC for ; Fri, 12 Nov 2021 16:38:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A8C8F601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hzdbRAogR2CYVW5psT3k2tRgJ8MhIdxBF3Let/yXG7w=; b=OsNGp3w/XKDV5J MIHTFnoPgOXKKMXZdBIq56Nw4RJ57yAHEKqzWuuqa2zNKDCHOlf5uI3DgI7bV/xGlk3I5r6fzTVcn MonYpoKCWR/Ew57n1+SoNefkw7qACdoa/k7PI8fyud+yFgtOulRadoUskNWNAJKvnAGZ5xYfE7X5x VooPITslmgTFC63DmZMBoT8P1lrfQrr1Pk5KrB7+ZiKnU5T+O1wdVgpphSY+5cgMANzi0e5t4WQqI A3yHBnlzm8Y4mpD6TUKFMck1C47cnyt3eAvxlQokW/dvvtYB9wAFi/Z051Kq22I7Cb/jh0RdczI2Q r0RLmPeMAbBdlqVKw6Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlZYa-00BFOI-NZ; Fri, 12 Nov 2021 16:37:40 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlZYW-00BFNF-OW for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 16:37:38 +0000 Received: by mail-pj1-x102a.google.com with SMTP id o6-20020a17090a0a0600b001a64b9a11aeso8035085pjo.3 for ; Fri, 12 Nov 2021 08:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e7iTg3uUKBh9ZxUEKYMGx8mtlJVEUn+H+Rz33T3uVoM=; b=nsrD4v0YgJYBV1mZ1AeZpmbbFBYYCsCQV08NgqAvaUEaOkHZbY4Hicec4VtYfXpAQF v9nOoUB+2PaHL6kqpW96ffOMv+g5cO0asAd813mcO3ZYJJQTVqW50d3Hz4Q6cwXI8M65 bjue0Q0Fy2vK088/JB9RwDOT4MMu45uwsQ1kSNxDxkSD46EluzKZRBy8+Z4DvYELW9eI KoSpTRSCC4Lu/DsAp6RJDceECZZu/pr8svArLW013D3wdEsGo17+H4Vbv2S2PcwtCGnl 7YbDPmmt0N+xv8DnXvS9NqePvcmtQw0tFXQn4wtl3lwpK7fDTNkDP1oobIdhCdcjM/JG iOhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e7iTg3uUKBh9ZxUEKYMGx8mtlJVEUn+H+Rz33T3uVoM=; b=QIoN/aTqWdKOgIWV+Q4RYubI9M3jzrNcVS36Pp5GMfgby7xLOHeyO38UJsP2+15KoC /khURm3l0/M43a67+7+zYIoXVOVxjlJS8XIZYRqlsSr649cVzOWkQB+r4fZlkcIUnIu5 G/H8A7MzbDhQRs1aJZ0wlwNuoshgov9HUp9e7jCjf5XcBwTpAscue7noYJ+KWffnH69L H7VsoMZa/3NzTTnVE0chTfIad8MxHAXHLVxv2vK8TIJiNOrbyHAaRMCMSI8Oe8b9lYcS c9uLe4fMUKHOYwn0NUlwxuHiu6HDYg8fsKcK3zCBqhsbuOB2QA0KRN6kqOOEiakfhkvr kEzg== X-Gm-Message-State: AOAM530PCFOOPbvhhwWGNETUALWA0GYNB4vcAO3jhgeFbPLj0dvlKPV1 b7L38Pxp4M1rRmQNY2yR7qgTXA== X-Google-Smtp-Source: ABdhPJyqZiOSqLeGTVRg61sYj3fTdcTrDH7d96OWC7ykTpqEP3q0BM+5wAszcMb6tNcCv7qred2RLA== X-Received: by 2002:a17:90b:1106:: with SMTP id gi6mr38305386pjb.115.1636735055562; Fri, 12 Nov 2021 08:37:35 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t1sm6719895pfe.51.2021.11.12.08.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 08:37:34 -0800 (PST) Date: Fri, 12 Nov 2021 09:37:31 -0700 From: Mathieu Poirier To: Jinlong Cc: Tao Zhang , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni Subject: Re: [PATCH 05/10] Coresight: Add interface for TPDM BC subunit Message-ID: <20211112163731.GA2162006@p14s> References: <1634801936-15080-1-git-send-email-quic_taozha@quicinc.com> <1634801936-15080-6-git-send-email-quic_taozha@quicinc.com> <20211104180106.GD491267@p14s> <20211105082625.GE25738@jinlmao-gv.ap.qualcomm.com> <20211112084228.GA24524@jinlmao-gv.ap.qualcomm.com> <20211112091034.GA28079@jinlmao-gv.ap.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211112091034.GA28079@jinlmao-gv.ap.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211112_083736_843300_0216B922 X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 12, 2021 at 05:10:38PM +0800, Jinlong wrote: > On Fri, Nov 12, 2021 at 04:42:31PM +0800, Jinlong wrote: > > [....] > > > > > > &tpdm_attr_grp, > > > > > + &tpdm_bc_attr_grp, > > > > > > > > It is quite tedious to review all these options at the same time as the core > > > > drivers. I suggest to concentrate on the base functionality for now. When that > > > > is merged we can add configuration options such as these. > > > > > > > > I am out of time for this patchset and as such will not review the remaining > > > > patches - those will have to wait for another iteration. > > > > > > > > Thanks, > > > > Mathieu > > > > > > > > > Thank your for all the comments. > > > We will update the patches. > > > > > > Thanks > > > Jinlong Mao > > > > > > > Correct the typo. > > Hi Mathieu, > > We will reduce the code changes. > There will be code changes below for next version: > > 1. coresight: add support to enable more coresight paths > 2. Basic function for TPDM(only enable/disable functions) > 3. TPDA driver > > Is that ok for you ? Yes, that sounds much better. Regards, Mathieu > > > > > > > > > > > NULL, > > > > > }; > > > > > > > > > > -- > > > > > 2.17.1 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel