From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2A0C433F5 for ; Sat, 13 Nov 2021 11:40:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C24461152 for ; Sat, 13 Nov 2021 11:40:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C24461152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eMfxy5EyT9HlT3CBGDkuXlf+wynb/gSwXx5pwyLRZDc=; b=MP/DMNLfUodEXC kOdPl7YyZMulVUlX7/gPLPUs5eBg9dHumlhlmFu8PTAiD2aY8i/ZwcAMGSV4Fk8y7RGkrzothn9Vo f5JxpKlK534Am9wOb5ic58S/QXCzam3oMbLxnOEHivL+VuTn3YacmAmCpEY0yJan4GCxWqIMSdZQ4 tDHVxFBqmTzdrXDDPakKfOq5iDqmZx4PmmFL52qgTVpGMXg4k5bVaWbfPCB8cFfmi63naBsZ5zsas ANMRPWCDsp3D0JCYmkU00SAKTaewXLY4R4IW+hBJ+1+XKVJHomZpdf11I7UzSAfcNk3iqVYySHZBn bDLPP+B9YAJoiMDEvtCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlrN2-00CXiX-IF; Sat, 13 Nov 2021 11:38:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlrMv-00CXha-Uo; Sat, 13 Nov 2021 11:38:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70EA2610A1; Sat, 13 Nov 2021 11:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636803528; bh=XnFsCOh7+ZQSvOwVOReC7fne9fxxNTruS9Wkfka6JZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S4gQK/TR/e8aa1qGhRiCxvwcgRYnKzPW3ga3Vj2AUhROup7f3YPZSGDqwsnUJc52w +L6FnKtCp5cVkKD6tjQzr17/CoUMwP33aPODqbewUZnBpMD+HJNn/G1yLhFJGd3yNu A0lXhgqsWUuISH4VAYYBdlBab3Cn3an5CmsHsGrP1krtCSBDbI8DPSDciRvdU//9Fl WXQ3JTIMpZ+ctuyPnKy0pbJxuZ8O+o3nvwHAiijbI+fPMVkfZcsS+RJioZjV6Ki3kg ofSNhvXCUFHwoTdopFhyJY9GC33KlooDijJ3LENwSdYDcqTMbWBQbFMc3K7w+vrgMw KId3eVvIzPikQ== Received: by pali.im (Postfix) id 5DD69819; Sat, 13 Nov 2021 12:38:46 +0100 (CET) Date: Sat, 13 Nov 2021 12:38:46 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Rob Herring , Saenz Julienne , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v8 3/8] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Message-ID: <20211113113846.oqdnov2hvbmlx5hi@pali> References: <20211110221456.11977-1-jim2101024@gmail.com> <20211110221456.11977-4-jim2101024@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211110221456.11977-4-jim2101024@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211113_033850_066718_4EB68DCB X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 10 November 2021 17:14:43 Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg pci-ep@0,0) for the regulator property. > > The use of a regulator property in the pcie EP subnode such as > "vpcie12v-supply" depends on a pending pullreq to the pci-bus.yaml > file at > > https://github.com/devicetree-org/dt-schema/pull/63 > > Signed-off-by: Jim Quinlan > --- > .../bindings/pci/brcm,stb-pcie.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 508e5dce1282..ef2427320b7d 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -158,5 +158,28 @@ examples: > <0x42000000 0x1 0x80000000 0x3 0x00000000 0x0 0x80000000>; > brcm,enable-ssc; > brcm,scb-sizes = <0x0000000080000000 0x0000000080000000>; > + > + /* PCIe bridge */ > + pci@0,0 { Hello! I think that above comment should be "PCIe Root Port" (and not PCIe bridge) as this node really describes Root Port device in PCIe Root Complex (correct me if I deduced it wrongly). lspci (-vv) show type of device on the line "Capabilities: [..] Express". > + #address-cells = <3>; > + #size-cells = <2>; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + compatible = "pciclass,0604"; > + device_type = "pci"; > + vpcie3v3-supply = <&vreg7>; > + ranges; > + > + /* PCIe endpoint */ > + pci-ep@0,0 { > + assigned-addresses = > + <0x82010000 0x0 0xf8000000 0x6 0x00000000 0x0 0x2000>; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + compatible = "pci14e4,1688"; > + #address-cells = <3>; > + #size-cells = <2>; > + > + ranges; > + }; > + }; > }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel