From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6980EC433F5 for ; Tue, 16 Nov 2021 11:35:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 332C361A08 for ; Tue, 16 Nov 2021 11:35:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 332C361A08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=38ubjEteXaRJq01tbSLHK7nWyb12ihX/KEtkHJm2wN0=; b=xSuXiTCiLeyghC wGwXVeCZFquvb/vImVf6DW0iW8ZZITM9XZKaHmSh47ASfDFj5xrBrZMwj2pv2ofC4WfvNw1B6/zE1 Tjq02KPEmBt4C8h7uuoXofneU5xWPj2zLSbruFAE72FLU+vyMwawhe98xCzQvlNRNsEUsht5oroiH 5O1E3Sl8MY1hcvRMARRn0bn3F2zCqIwM8q+Gxw2s+OSK5LPBDkoE6Qo+e5sGo20ywsCZ8dPQ4HGRJ 9Cct4ikYjRG5H4L73O6TXUVsAuP+U0GmcVBQtwxeuHxBE77kvxTbTj8vOdW1604kqnkglqloRepNB Z2caW6NkSr6N3gDu/JoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmwhr-001Skm-MP; Tue, 16 Nov 2021 11:32:57 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmweJ-001R4e-AJ for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 11:29:21 +0000 Received: by mail-lj1-x236.google.com with SMTP id t11so42528721ljh.6 for ; Tue, 16 Nov 2021 03:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KgH8hxHm/FrDWe8yu/KtutrLYb/eHAySYSG7tABVZD8=; b=WQXwJtlQVd+47QBnnFnwMnHb+unQnWJRVp8wa0AAzlb+m5V+4E+gTCt24sAj6B+xxt 0rlCxO8r9bnoJFqpL0pyGjT8MmhgYrolx5H6mBWDWMYoneuhLPnvtMUzQlkuEy6Qfb+K aMoyWbKCGA03sRWgwyTm+66RhHAlpLbu3ZzjG3MUverXK1LlZ70OPYkvA7uxllqr5EdW Ynee/tWnWOjd3LKBwmADf1dGMGAQfiMm/9ZJT/tthXNR1a8Xv+W8g5T4EYW20We6a8Oo 6pmb1HVHbsushdwxfYUN+yWOeoYhokFpirI0P5DGS9lAiJ2fLv9X6CdCKuFRio9gHv2y QMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KgH8hxHm/FrDWe8yu/KtutrLYb/eHAySYSG7tABVZD8=; b=pyMxqBFxCGJoYpyInC0YO08nXOzH6dC/NbIMU3JDIWEDFrgybzA7xaatz+hosqr9k5 L3Ry5/WXXgDfOmxjNrwEoWrWp3AISAyZgeWAvYr6gRsRRuOSMN60YzeuOmXDLUZyXxKJ bh0yIZnsBxJF40aPrBgNWUKlH5a4l6tcA6Cf5L55zDlrhfDa/vxNz5+AreRdnZQ8zlds VM+1Q2bIMRGyJBpyLohuw7M7l/NT+hc6GjYd3HcXOPwoAFaQpcoxVxJJYMdJIBsxF2XA ZDS8iUcpXEIjQuT9iPTgeV4ancDBM1c2CvxlXEZ4O9vi+cqWAEkNCBTMe3cuvwsDnO3O ndSA== X-Gm-Message-State: AOAM533cKYwfx0zONPKx3VVWgs5iG9td4Hvwes6cRHbIjf0LBpn+RhoU QKktjUeCrPOgWkZ7OG7yi43Fz8cOF53z6A== X-Google-Smtp-Source: ABdhPJwT05xYGdFvFfnRIzfOHSrJKu1dUYSKUfjYX/R14U1ARea6ixOoVJqMNgE6F5QYwh5yfRZxWQ== X-Received: by 2002:a2e:7807:: with SMTP id t7mr6110206ljc.426.1637062150438; Tue, 16 Nov 2021 03:29:10 -0800 (PST) Received: from mobilestation ([95.79.188.236]) by smtp.gmail.com with ESMTPSA id m16sm1485527lfj.59.2021.11.16.03.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 03:29:10 -0800 (PST) Date: Tue, 16 Nov 2021 14:29:07 +0300 From: Serge Semin To: Brad Larson , Rob Herring Cc: Serge Semin , Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Subject: Re: [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings Message-ID: <20211116112907.lbwdcz5pmgxqzv55@mobilestation> References: <20211025015156.33133-1-brad@pensando.io> <20211025015156.33133-6-brad@pensando.io> <20211028074945.rv2j5kgzk7yc2srr@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_032915_427838_8240FD3C X-CRM114-Status: GOOD ( 31.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 15, 2021 at 02:24:40PM -0800, Brad Larson wrote: > Hi Sergey, > > On Thu, Oct 28, 2021 at 12:49 AM Serge Semin wrote: > > > > On Sun, Oct 24, 2021 at 06:51:50PM -0700, Brad Larson wrote: > > > The Pensando Elba SoC has integrated the DW APB SPI Controller > > > > Please add the "dt-bindings: " prefix to the patch name and discard > > the word "bindings" from the title as the submitting DT-patches > > requires: > > Documentation/devicetree/bindings/submitting-patches.rst > > I'll add that. I recall looking at the recent git log for similar > changes to the file as the current recommended approach. > > > > > > > Signed-off-by: Brad Larson > > > --- > > > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > index d7e08b03e204..0b5ebb2ae6e7 100644 > > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > @@ -73,6 +73,8 @@ properties: > > > - renesas,r9a06g032-spi # RZ/N1D > > > - renesas,r9a06g033-spi # RZ/N1S > > > - const: renesas,rzn1-spi # RZ/N1 > > > > > + - description: Pensando Elba SoC SPI Controller > > > + const: pensando,elba-spi > > > > AFAICS from the driver-part of the patchset it's not enough. You've > > also got the syscon phandle, which needs to be reflected in the > > bindings. That also makes me thinking that you didn't perform the > > "dtbs_check" on the dts-files you were going to submit, but for some > > reason discarded from this series (btw why?). If you did you would > > have got an error of an unevaluated property detection. > > I ran the checks below and didn't get errors. Rob provided some info > and I found the server did not have yamllint installed (not flagged by > tool). Also dt-schema was not the latest. I'm re-doing this and > including "DT_CHECKER_FLAGS=-m" as that is new with v5.13. > > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/pensando,elba.yaml Hmm, that's weird. Rob, does dtschema tool have the "unevaluatedProperties" property support? Brad, anyway you still need to add the syscon-property (pensando,*spics) requirement in the snps,dw-apb-ssi.yaml schema. See the way it's done there for instance for "baikal,bt1-sys-ssi" when it comes to the vendor-specific properties definition in the allOf composition block. You'll need to define a custom phandle property there in case if a DT-node is compatible with you SPI controller. -Sergey > > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/pensando,elba.yaml > > Thanks > Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel