From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C247FC433EF for ; Tue, 16 Nov 2021 18:48:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 847116101B for ; Tue, 16 Nov 2021 18:48:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 847116101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R4elyiS7bFsS8Iep9Py5eM0EQOqHTNm5jtoGtYS8p3U=; b=ln+I4MuSQP352U N+324H0Im1szclWbtRdWGkRJrb3A6oVgmEVGhBzpHR7qN7yUEullJo6emvoaWCNnRIal//X1Cckq4 Tg6hVwJh++rL4nk8SCny0jvXFQwIE8f+jkvAS1I7ZR7V51DJCuPd+M85gT2jJ2+URC+ba6WL5q6+G R7pI3sKSeqRikCdSfcsJJnE4gfSp2i+5rNVMBwcwb5snfavwjQz9sa5Kk9ayS1hwc+F/WBkZIxWl7 0J1qLEd5x59rW6uv++MKFrfQiTVbZw1950bzFNzmQMcgNN2Xw1Hrn2MHOCGRY30k6l09+Umifm2vn bUNDQELQfD5GCVE/4CtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn3Ug-002b7a-W8; Tue, 16 Nov 2021 18:47:47 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn3Ud-002b6t-VG for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 18:47:45 +0000 Received: by mail-pf1-x434.google.com with SMTP id r130so254876pfc.1 for ; Tue, 16 Nov 2021 10:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5A7EYLAA7hSd+CWAPJgku7+U4Q5GnEVCsQPwqfwVunQ=; b=zXsLWJq8YZDAWNJiS1/Au9aRJK3b6nxmAJ5+uNpL/L+/zxGE2EQBbyIyF/6SgswpBb yrcGQbtCYObPaiFIfGZU6n7d5RJLXus4koY8gpoH4R2qBvb6aZaRqXXKtn4L8BYJdYRK jp+pY60T997RdeayMLSo88VDWZiS5ETnlsKeT3qLogwBtKh3af4fzDliVOGW4ZliFvnt 8pdZZKmDII50cBjquvalbB6bAkLz777PyZixixO/I6SzwnAQXI9+Z6SCsKjzmfaAcISG bD5XzpPKRgI2K9/qUfPRZyKrDh8PPowIE/roW+XpL9Qx66Q03YeQ5nWgNthWH34KguRQ GoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5A7EYLAA7hSd+CWAPJgku7+U4Q5GnEVCsQPwqfwVunQ=; b=Fx/K9CzScx2LdshD9fjsn5jy5YrvMeMrQ7lbk+CB8EllKpzA3B6b+8zbE3OJq8u8OW 6znXFASP52iG+FfsbLJ56I/ujCs3UPVyWof0CxJCRbf/ow7G7FUgiMYhtTWc1h1WMpOX udwfD4ewSRCcs4knlbtf4RtaLUOTiN81qk/2QzQRbKXePePz2GAuQhq9Wb+58U2lw8yk 4ARJo+CHOCB0vVrd7PEly/n3h1Yg9c8xgUtNWeswgG+/pvjcyaAVnZD1tJzsJatQIeVU fUpQTu/oxnsYZKtgjTStT0pYah93hbi6L10PNHpS7+jxD6Rv01X9ug6odpwLhbeW84gb aeGw== X-Gm-Message-State: AOAM532E+ErhdV7FkNpww5NoXptN6ghTOO4H0bPTaL2a75EhfXbgTs0e 1/He/9Kh2kvFDah1S7CISiS503iR5Miogg== X-Google-Smtp-Source: ABdhPJz6rwB0NI6nTE4no/y6uRy8N8F9l6NATyKKGz9GritzFxr93NWy0UxjG2NbR9Rv1u8KRWnW4A== X-Received: by 2002:a63:d00c:: with SMTP id z12mr828277pgf.334.1637088462647; Tue, 16 Nov 2021 10:47:42 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q89sm3179707pjk.50.2021.11.16.10.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 10:47:41 -0800 (PST) Date: Tue, 16 Nov 2021 11:47:37 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , kernel test robot Subject: Re: [PATCH] remoteproc: coredump: correct argument 2 type for memcpy_fromio Message-ID: <20211116184737.GA2324186@p14s> References: <20211110032101.517487-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211110032101.517487-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_104744_045441_4DC5B5A2 X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On Wed, Nov 10, 2021 at 11:21:01AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Address the sparse check warning: > >> drivers/remoteproc/remoteproc_coredump.c:169:53: > sparse: warning: incorrect type in argument 2 (different address spaces) > sparse: expected void const volatile [noderef] __iomem *src > sparse: got void *[assigned] ptr > > Reported-by: kernel test robot > Signed-off-by: Peng Fan > --- > drivers/remoteproc/remoteproc_coredump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c > index aee657cc08c6..f39c98aa1b49 100644 > --- a/drivers/remoteproc/remoteproc_coredump.c > +++ b/drivers/remoteproc/remoteproc_coredump.c > @@ -166,7 +166,7 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest, > memset(dest, 0xff, size); > } else { > if (is_iomem) > - memcpy_fromio(dest, ptr, size); > + memcpy_fromio(dest, (void const __iomem *)ptr, size); Shouldn't this be (const void __iomem *) to respect the signature in [1]? [1]. https://elixir.bootlin.com/linux/latest/source/include/asm-generic/logic_io.h#L71 > else > memcpy(dest, ptr, size); > } > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel