From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84401C433EF for ; Wed, 17 Nov 2021 05:23:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4413761A03 for ; Wed, 17 Nov 2021 05:23:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4413761A03 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rkIsbz9zwvS/iGKZN9IeV6IYZX2twVRbPc5zwhcfTbw=; b=NfHI7/HO/PoYiJ uVrpnKR9pnMVN8DAL94nSAej+4O03el7HDsFV2JWxLhnZct5Dd4KTc2HtOkpbK04plzP7tTqSggc1 hbVALWYoXCCUcHh/j4A/zx7nh65sgkx33iXpxbQua5hwqVjm1dQjhLX3Y4t+HtZGGYI+laUIHmuGR mNDJXlP64V+vum7Ri9rbL0P6Y929PfqdOddQhlxKRtMbztcOxQ8o/n7CpsjisEdFN7+N7zRBQmff+ DtrpARcLKE5AkUt5N7IoUmdrHV0U3OyFtzzdhyZFdHCAOijWzcc58/tbDVOgY5gwbUp1ozEerv5OA L5YvMEMTa2GhFIa/hMrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnDOR-003LYr-62; Wed, 17 Nov 2021 05:21:59 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnDON-003LXu-6k; Wed, 17 Nov 2021 05:21:56 +0000 Received: by mail-oi1-x231.google.com with SMTP id u74so3770097oie.8; Tue, 16 Nov 2021 21:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bqNOr2tcjMGEh27YaG51I8jTVanWEeuncxzB9qiBcBs=; b=bl+IKYslLDCVHLv4sY58rETgjZyYSivbPHaVb5YuVLBH3xd/N1qr5SYwLP+v06AE6f syIIZwhV4mjmNlK2sApSFLjXs+ctX2T4HY8bkhFdljdQPlnFes1nuis6AQOQwIiBLmJB 7ux6fi+0FFnGI10X5OAuCl3M6P4Yz289NL1Mge59h9Bad3J+mbJpu+Grl6OT7fX9snFu n4t4NFWjrKAcHma8xtmY56nHDn76Kf0sEbHIhUHrDyMwVSHEiKmekKzCMFWsugsSM6LZ j6SnvOFD0pQt91yTR0Pao7tbyRwxC5iCpflzP2tNLDUbJIhPnZe16guNUlzke8bIESsh MqTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=bqNOr2tcjMGEh27YaG51I8jTVanWEeuncxzB9qiBcBs=; b=unOIX3Xgow1s66uangzbs4F1vXhiWg6+F+/e3EeJ1Bf9sGovgtn2K3vyFmbrMaoGFw vy/g9vilZgaJZrAmE1/kDR1YK9NhMsnTVBZ5YTq0rX14KjkzcVMrtJLSicDveb9wxPMn V9kd5/xnlyYEIpN2chARgi7GK5R1I+zSn4BlccDHZdRsqou9IBA8mtnsnJSjRQZp6Xa5 eXrhJRgJVLTX8sUgYoYfRisijBBjAEWpzF4t1tbM56KsWUleUfCzLvPR+r45DvfdnEmH c2/gZ+rJKlcCEJQVewHSf++Crfv3OdcFnalqNrzHDd2ubfP0kwZR8rbRFsce0CMHOMCs 0HnA== X-Gm-Message-State: AOAM531+NVyOfv8+UbHdQsH9VHnCc1GkaNgy+m/6nfjWSeoiYpJd0twp 9x0JJmY7AzwWax5DH1R+0IY= X-Google-Smtp-Source: ABdhPJyZzZnS6l7no0N3RdxSUIklHfaadp2OLTJVskClufO2YOsIfTJ7lpXEpo1Eer2g/smNFmW81w== X-Received: by 2002:aca:d07:: with SMTP id 7mr11526403oin.92.1637126509331; Tue, 16 Nov 2021 21:21:49 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id z14sm3977894otk.36.2021.11.16.21.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 21:21:48 -0800 (PST) Date: Tue, 16 Nov 2021 21:21:47 -0800 From: Guenter Roeck To: Artem Lapkin Cc: narmstrong@baylibre.com, wim@linux-watchdog.org, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: Re: [PATCH] watchdog: meson_gxbb_wdt: remove stop_on_reboot Message-ID: <20211117052147.GC215087@roeck-us.net> References: <20211110022518.1676834-1-art@khadas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211110022518.1676834-1-art@khadas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_212155_271057_5648AF11 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 10, 2021 at 10:25:18AM +0800, Artem Lapkin wrote: > Remove watchdog_stop_on_reboot() > > The Meson platform still has some hardware drivers problems for some > configurations which can freeze devices on shutdown/reboot. > > Remove watchdog_stop_on_reboot() to catch this situation and ensure that > the reboot happens anyway. Users who still want to stop the watchdog on > reboot can still do so using the watchdog.stop_on_reboot=1 module > parameter. > > https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@khadas.com/T/#t > > Signed-off-by: Artem Lapkin Reviewed-by: Guenter Roeck > --- > drivers/watchdog/meson_gxbb_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 5a9ca10fbcfa..3f86530c33b0 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -186,7 +186,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > > - watchdog_stop_on_reboot(&data->wdt_dev); > return devm_watchdog_register_device(dev, &data->wdt_dev); > } > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel