From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E64C433EF for ; Wed, 17 Nov 2021 14:55:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D36161B1E for ; Wed, 17 Nov 2021 14:55:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D36161B1E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/PTHW8bAsXT+0TK4YjrE0Yci+oMPsUEUIt8InpG+BzQ=; b=CF3MLtkb+dZ9Uv Gwe9gy65Ogn5mHVoKjy9Y7dsgwK9ooO32AKWUPdydMKCokgE1arJTfdIXapb4TNaTEb/evadCfQoK TwRvyV8eF0I1BliuIYugLd7F4bjsZPF6XcwlVfCZ8j63g3mvUdLp1QjSMVGcadPCJXZy4+kIqciSR G4VIEe2fpsW9Uo1xI1dyx3/fGDyj8pb6oSDgqPEoYLrbZdVHi6kkIUY1CqL62/W8RBRzUu+jku8X5 55WAGkwpwhgoseIzJ/4cxdjPDJiRxc816gYuUzfAZ6zBK61HTkl2P4VTrqpzl4lN9rznhv/BXpCBJ XLZrmwp+Q4p6WdW7XhAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMJi-005F8P-FG; Wed, 17 Nov 2021 14:53:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMH3-005EB6-FS for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 14:50:59 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMH1-0000XG-Hs; Wed, 17 Nov 2021 15:50:55 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mnMH0-0001C9-9I; Wed, 17 Nov 2021 15:50:54 +0100 Date: Wed, 17 Nov 2021 15:50:54 +0100 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional Message-ID: <20211117145054.GL6556@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-12-s.hauer@pengutronix.de> <15744316.EhFUcUTHNY@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <15744316.EhFUcUTHNY@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:44:50 up 272 days, 18:08, 147 users, load average: 0.28, 0.17, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_065057_594337_FA2788A8 X-CRM114-Status: GOOD ( 26.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko St=FCbner wrote: > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > the VOP driver optional. > > = > > Signed-off-by: Sascha Hauer > > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > > arch/arm64/configs/defconfig | 1 + > > drivers/gpu/drm/rockchip/Kconfig | 7 +++++++ > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > 5 files changed, 12 insertions(+), 2 deletions(-) > > = > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/mul= ti_v7_defconfig > > index c951aeed2138c..fc123e8f3e2f9 100644 > > --- a/arch/arm/configs/multi_v7_defconfig > > +++ b/arch/arm/configs/multi_v7_defconfig > > @@ -667,6 +667,7 @@ CONFIG_DRM_EXYNOS_DPI=3Dy > > CONFIG_DRM_EXYNOS_DSI=3Dy > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > CONFIG_DRM_ROCKCHIP=3Dm > > +CONFIG_ROCKCHIP_VOP=3Dy > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > CONFIG_ROCKCHIP_DW_MIPI_DSI=3Dy > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index f2e2b9bdd7024..a623386473dc9 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -682,6 +682,7 @@ CONFIG_DRM_EXYNOS_DSI=3Dy > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > CONFIG_DRM_EXYNOS_MIC=3Dy > > CONFIG_DRM_ROCKCHIP=3Dm > > +CONFIG_ROCKCHIP_VOP=3Dy > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > CONFIG_ROCKCHIP_CDN_DP=3Dy > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchi= p/Kconfig > > index 9f1ecefc39332..a1c4158259099 100644 > > --- a/drivers/gpu/drm/rockchip/Kconfig > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > @@ -21,8 +21,15 @@ config DRM_ROCKCHIP > > = > > if DRM_ROCKCHIP > > = > > +config ROCKCHIP_VOP > > + bool "Rockchip VOP driver" > = > would this benefit from a default-y ? > For builds reusing preexisting .configs. I enabled CONFIG_ROCKCHIP_VOP for all configs in the tree that enable CONFIG_DRM_ROCKCHIP, so defconfig users shouldn't see any surprises. That won't help users of custom configs of course. I don't know what's preferred in such cases, I can change to default-y if you like. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel