From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0250C433F5 for ; Wed, 17 Nov 2021 21:41:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98753613D3 for ; Wed, 17 Nov 2021 21:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 98753613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=poueNBVuuPppcsFghYdAlUn/v2Nc0eTIH2EwC5dlKRc=; b=0KsHHauQ+AhssM zPg0UJs8c9ep84mpquWcsRew51aUE3itcvX18sjF+WHKNr50WirA+IgN8Lj9k1XhKddMLP+E348Ys 4FVt05MZXGadrweXrmXVGOuXYZgePySMnjFB72fSvk203z7icYy/IZ18ewEpcrAijdeEhepYC6fcF 4lko9Jw/ph8uxBND/1dKJdlrc/sqhI0G99iodiJaffF6xvgTDaXnKqYso0XCbd8RfTeBeE5ynaLE6 5nL54MU8OlcD6SttTkW4iZ+VHgVYSA/M6phkXNn6o6xFfh8ufqSiPXGL7PRagmvUWtTsFpWDkoiCa Lwb/nSvqI5Vf0q0SFGXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnSey-006KXf-DW; Wed, 17 Nov 2021 21:40:04 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnSet-006KWr-UE for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 21:40:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JFZEUOPWf1/nxGeGtVRYuWseGaRsxvnuJVELp2zrJLw=; b=cI6tiWIw8UrB0NnC9bDlb7IRkj 9VyLjEXqJiZ+ikt0/0lKIZ2hFeU19SmbUsmRMKLCMLoGhhZVZv6d2n1qo0FaLeXNe7xo377hbPO1j pfztujetrGwJ3qq+Ri2v4hSEzw143ca3BxZLu0Qq2wwK+beGN04s3lCP7b7BPRzVbxpU=; Received: from p200300ccff0ece001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0e:ce00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mnSel-0004n2-UB; Wed, 17 Nov 2021 22:39:52 +0100 Date: Wed, 17 Nov 2021 22:39:50 +0100 From: Andreas Kemnade To: Alistair Francis Cc: lee.jones@linaro.org, broonie@kernel.org, kernel@pengutronix.de, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, rui.zhang@intel.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, s.hauer@pengutronix.de, linux-hwmon@vger.kernel.org, amitk@kernel.org, linux-pm@vger.kernel.org, linux-imx@nxp.com, alistair23@gmail.com, shawnguo@kernel.org, Rob Herring Subject: Re: [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Message-ID: <20211117223950.3a7eaf7a@aktux> In-Reply-To: <20211110122948.188683-2-alistair@alistair23.me> References: <20211110122948.188683-1-alistair@alistair23.me> <20211110122948.188683-2-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_134000_191604_0D95C8DE X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 10 Nov 2021 22:29:41 +1000 Alistair Francis wrote: > Initial support for the Silergy SY7636A Power Management chip > and regulator. > > Signed-off-by: Alistair Francis > Reviewed-by: Rob Herring > Acked-for-MFD-by: Lee Jones > --- > .../bindings/mfd/silergy,sy7636a.yaml | 79 +++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > new file mode 100644 > index 000000000000..0566f9498e2f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml [...] > + regulators: > + type: object > + > + properties: > + compatible: > + const: silergy,sy7636a-regulator > + > + vcom: > + type: object > + $ref: /schemas/regulator/regulator.yaml# > + properties: > + regulator-name: > + const: vcom > + hmm, this is what? If I understand it correctly, vcom means some voltage for compensation. On other comparable pmics (e.g. TPS65185 which has also a sane public datasheet, MAX17135) I have seen some methods to measure a voltage while the display is doing something defined and then program this voltage non-volatile for compensation during manufacturing. If I understand the code correctly all the bunch of voltages are powered up if this one is enabled. So at least a description should be suitable. The other comparable PMICs have at least regulators named VCOM, DISPLAY (controls several regulators, started with delays configured via registers) and V3P3. MAX17135 source can be found in NXP kernels, TPS65185 in Kobo vendor kernels. So I would expect to see something similar here and a description or at least not such a misleading name as vcom if it is for some reason not feasible to separate the regulators. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel