From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C9DC433EF for ; Thu, 18 Nov 2021 15:15:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48887615E3 for ; Thu, 18 Nov 2021 15:15:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 48887615E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1U4t2m2tIYDl371vHoCmFTSY8mNtHXqbfg7Kxqdofe0=; b=j7uMdeM4l3NKnF Z7PiNKs7+WwA/7v2hINKyLITLjxlSHGnAK0oQz772qhEYdbvimmTLM0OkONJiUxDacHlFAoMYJbz0 V/udh1eB2zZGW3IviunZT2Cc2nzqLe7n6wVy2nHnlqrIngkFWi/woTvDPawiEPvvY6H29b7R8S/QF Xc22XmUVg/GHQjhD4c2O/lSz2wEB3DJ0QS2e1un8z+HZxwwByu+e+i4Do8AehGFJQrhFHJK6/XOWx D3U3Zkq8WOqptOS6+M0pknFEGSPh/Wm4PKNvjK4wWOw60jXnrMJg1r4qOlYPwzQacjzZJ07FIFTia T9TMhoiXQV8NLg0Ryb+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnj6g-008Dso-LE; Thu, 18 Nov 2021 15:13:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnj6a-008Dpk-Ss for linux-arm-kernel@lists.infradead.org; Thu, 18 Nov 2021 15:13:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AFC4D6E; Thu, 18 Nov 2021 07:13:37 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CF3F3F766; Thu, 18 Nov 2021 07:13:36 -0800 (PST) Date: Thu, 18 Nov 2021 15:13:28 +0000 From: Mark Rutland To: Jisheng Zhang Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: extable: remove unsed ex_handler_t definition Message-ID: <20211118151317.GA9977@lakrids.cambridge.arm.com> References: <20211118200249.73172ce5@xhacker> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211118200249.73172ce5@xhacker> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_071341_048798_BCDAC3F2 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 18, 2021 at 08:02:49PM +0800, Jisheng Zhang wrote: > From: Jisheng Zhang > > The type ex_handler_t is defined but not used, remove it. It's probably worth saying: | The ex_handler_t type was introduced in commit: | | d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields") | | ... but has never been used, and is unnecessary. Remove it. ... as this was a leftover from a prior version of that patch, and in the form merged in mainline it was redundant becuase we moved to using an enumerated type rather than a function pointer in the ex_table_entry. > Signed-off-by: Jisheng Zhang With or without the wording above: Acked-by: Mark Rutland Thanks, Mark. > --- > arch/arm64/mm/extable.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c > index c3d53811a15e..c0181e60cc98 100644 > --- a/arch/arm64/mm/extable.c > +++ b/arch/arm64/mm/extable.c > @@ -10,9 +10,6 @@ > #include > #include > > -typedef bool (*ex_handler_t)(const struct exception_table_entry *, > - struct pt_regs *); > - > static inline unsigned long > get_ex_fixup(const struct exception_table_entry *ex) > { > -- > 2.33.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel