From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F368C433F5 for ; Thu, 18 Nov 2021 18:31:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E25B61360 for ; Thu, 18 Nov 2021 18:31:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4E25B61360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=udN0wo31T/C5StgUrhC6gMrEejPeknj66nxBSe3maB4=; b=QZbntiQsBHtoVS fCknX8TNpIwHaDUb9UZLjc7bU68QdxF9ZB6loQS2Z1UMNpR7lB5/dyV0d9/fdQc9wnJmXRaJiSGxi KONdjwUinpNyoW+VbePR/72r+DQCaDS938a5fjf2VFoEV0fqcBZF+jGXO3wz8vrBeoNU/258N3meh i6v+I4JDonUc/cPgklVWuMJNEjd6wV7gAQRKnmlbWTQw/OdKoP4TbHkDZH2mdhfCTbHJtUEnZMpPc 1o9CDDLet1eDL9tP93xm17O4wlkowC5fdr6col2TejDqmuhXuDKBTxzTivMx0uN2l/SGBlB1ygDr/ LbojQVuX+HHZ56SJYxmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnmA4-008Ymi-H1; Thu, 18 Nov 2021 18:29:28 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnm9n-008YjZ-FM for linux-arm-kernel@lists.infradead.org; Thu, 18 Nov 2021 18:29:13 +0000 Received: by mail-pf1-x42a.google.com with SMTP id z6so6866872pfe.7 for ; Thu, 18 Nov 2021 10:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uSpY8+ZZw7VrKc1FtbyhIu09kHALiBf3b1wB2/ERM84=; b=FFDOLGcNCvLCzew0kAl/PrKO6GF2WJn0StIk8lHWGW/Nsegh4lz7mceUZxz0rj3xpg zv9r0YDfv48Tk0S2QuVib3gTJYpn7lsBm+mgXLUjl0dA7OtUV/twZggjJT5/XLGQ1Lgo yJCThsCKqhtw7RYN0FPeMP7R4JimYDPQiA/HNJSHS+gJr1Nra7mJF6bhXbWZCqcgdXGi OD+PN1T/Z3IMbXTAerzxq7ZO8dt2mO4dgwnHyTOGsyb0iqWO5Mcpx2Ws84AeZjPhUHXv 506ausdqvVSQpNg//HRe3ZUWt52rGUt9eLhqPWTphicODw1IjaEM6xPTYtxQuDiplH5g DyJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uSpY8+ZZw7VrKc1FtbyhIu09kHALiBf3b1wB2/ERM84=; b=Qi+nVwz7GYcX1I8BrMZIZNp2+NlP+WUQa63+hNDjocNGuK7zILoUZ4JXydT+/iEBK8 V7/dSgtcWtkzNxH63yNEvmgsrU+nOhyaRSB4xRkJTJuZV+iG3y9MBA1zrL5p7SOOnQRw tWRN8JkyQ1KotmN9CFPTgCg/WcX1TiBEihNwh0MX1ywmzq0rk7tkjrl2jKrNj+4f8Jyc Y9gkx/fBWUNzP5Td2UO3S3o2ZILOZ13z3GeTl/kOC+NXq4ppsUnQvVpDCHD7Nmswg26Q FIaD05m/WTAyp8Ho78QiYDzWSOYi3/nZgDWwX+L/HDnGPO0OFovvkRGB2HOOUsWiwVGT lKeA== X-Gm-Message-State: AOAM530oFmKXk1n4dT2/f6yuZJXlto+XoRRM/xc/XxwvsZsHVu+G51pO 9OGnq1V6K+DGvolHbDG2YHckhA== X-Google-Smtp-Source: ABdhPJwy3KjQMrd7Y6BMNeVoxIqHpThnIeHkISg6+ofmx1GlKl2PNcRgVasH/MbvMqrZYDcJwBeo4g== X-Received: by 2002:a05:6a00:181a:b0:47c:1057:52e with SMTP id y26-20020a056a00181a00b0047c1057052emr17426322pfa.76.1637260149673; Thu, 18 Nov 2021 10:29:09 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id v15sm298349pfu.195.2021.11.18.10.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 10:29:08 -0800 (PST) Date: Thu, 18 Nov 2021 11:29:05 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table Message-ID: <20211118182905.GE2530497@p14s> References: <20211112063416.3485866-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211112063416.3485866-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_102911_587897_B4F47EB5 X-CRM114-Status: GOOD ( 28.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On Fri, Nov 12, 2021 at 02:34:16PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > When loading elf and kicking M core from Linux, previously we directly > use the address of the resource table in elf file. After i.MX8MN/P > RDC enabled to proect TCM, linux not able to access the TCM space It would be nice to know what RDC is and what it stands for. Moreover I assume you mean "protect" here when writing "proect". > when updating resource table status and cause kernel dump. How was it possible to boot an i.MX8MN before this patch? Why wasn't this part of the patchset that introduced support for the i.MX8MN? > > So let's check whether rsc_table is available, if available, we use this > address. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index ff8170dbbc3c..96a56ab39ccb 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -497,6 +497,17 @@ static struct resource_table *imx_rproc_get_loaded_rsc_table(struct rproc *rproc > return (struct resource_table *)priv->rsc_table; > } > > +static struct resource_table * > +imx_rproc_elf_find_loaded_rsc_table(struct rproc *rproc, const struct firmware *fw) > +{ > + struct imx_rproc *priv = rproc->priv; > + This is lacking proper documentation. Please specify which remote processor is supposed to find a resource table address in the device tree and which should rely on the address in the resource table. It would be much better to rely on the remote processor model to decide where to get the resource table from, and return an error if it is not where we expect it to be. Thanks, Mathieu > + if (priv->rsc_table) > + return (struct resource_table *)priv->rsc_table; > + > + return rproc_elf_find_loaded_rsc_table(rproc, fw); > +} > + > static const struct rproc_ops imx_rproc_ops = { > .prepare = imx_rproc_prepare, > .attach = imx_rproc_attach, > @@ -506,7 +517,7 @@ static const struct rproc_ops imx_rproc_ops = { > .da_to_va = imx_rproc_da_to_va, > .load = rproc_elf_load_segments, > .parse_fw = imx_rproc_parse_fw, > - .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, > + .find_loaded_rsc_table = imx_rproc_elf_find_loaded_rsc_table, > .get_loaded_rsc_table = imx_rproc_get_loaded_rsc_table, > .sanity_check = rproc_elf_sanity_check, > .get_boot_addr = rproc_elf_get_boot_addr, > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel