From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
georgemakarov1@gmail.com, peter.chen@kernel.org,
otavio@ossystems.com.br
Subject: Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
Date: Mon, 22 Nov 2021 09:23:38 +0800 [thread overview]
Message-ID: <20211122012337.GU31998@dragon> (raw)
In-Reply-To: <20211118095934.1138604-1-festevam@gmail.com>
On Thu, Nov 18, 2021 at 06:59:34AM -0300, Fabio Estevam wrote:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
>
> Add an entry for the correct name and still keep the old one to
> avoid potential breakage.
>
> Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
> Reported-by: George Makarov <georgemakarov1@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6ull-pinfunc.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h
> index eb025a9d4759..b492164e8cfb 100644
> --- a/arch/arm/boot/dts/imx6ull-pinfunc.h
> +++ b/arch/arm/boot/dts/imx6ull-pinfunc.h
> @@ -82,6 +82,11 @@
> #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
> +/*
> + * As per the Reference Manual the correct name is ESAI_TX0.
> + * Keep the old name here to avoid breakage.
> + */
> #define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
I don't see any user of it, so should be be safe just to remove it, no?
Shawn
> +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
>
> #endif /* __DTS_IMX6ULL_PINFUNC_H */
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-22 1:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 9:59 [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0 Fabio Estevam
2021-11-22 1:23 ` Shawn Guo [this message]
2021-11-22 1:46 ` Fabio Estevam
2021-11-22 11:11 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122012337.GU31998@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=georgemakarov1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=otavio@ossystems.com.br \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).