From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAB17C433F5 for ; Mon, 22 Nov 2021 08:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WF7LKYofODRQq0vF22IjawgXnwxIJvA0zcUIUwABWtQ=; b=V6mDRgQo6BU/wz VlYVW8xcyPP9GPNq/IDtDG6THmGltNqHWaIsAgxFsYKnphYcuOpCcgDUc6UVChO0h4NZlGi5gGPfg ePmLLIXr0AmCch+dc02qFFEto+8vPA4FIAk1j+MFtZKc36NXHqfF6rwllcXwJJep1wLHmzbyfnaoM cyRuAmHf8ssUqD9xQlbxrmIrH4SvQR6dSIS2l7OweHxtnOlOrkBsVGCBeYN6OV94OgTyieM9zX287 CrGDGldJrtN12P87CN1A9pZRVjttGtIKb1TtsqyuBCZBJ+vKMkzQmRr7RiG0Sj+7N7ayRPJhpuddI 5n0XisHozk/EdkoJmodA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp4nF-00FJSZ-22; Mon, 22 Nov 2021 08:35:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp4n9-00FJRn-DT for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 08:35:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D5936D; Mon, 22 Nov 2021 00:35:07 -0800 (PST) Received: from bogus (unknown [10.57.46.248]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9EAB3F5A1; Mon, 22 Nov 2021 00:35:05 -0800 (PST) Date: Mon, 22 Nov 2021 08:35:03 +0000 From: Sudeep Holla To: Michael Kelley Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, steven.price@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla Subject: Re: [PATCH 1/1] firmware: smccc: Fix check for ARCH_SOC_ID not implemented Message-ID: <20211122083503.umkqv2t75osypsbx@bogus> References: <1637365141-16823-1-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1637365141-16823-1-git-send-email-mikelley@microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_003513_464015_A4E0A11D X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 19, 2021 at 03:39:01PM -0800, Michael Kelley wrote: > The ARCH_FEATURES function ID is a 32-bit SMC call, which returns > a 32-bit result per the SMCCC spec. Current code is doing a 64-bit > comparison against -1 (SMCCC_RET_NOT_SUPPORTED) to detect that the > feature is unimplemented. That check doesn't work in a Hyper-V VM, > where the upper 32-bits are zero as allowed by the spec. > > Cast the result as an 'int' so the comparison works. The change also > makes the code consistent with other similar checks in this file. > > Fixes: 821b67fa4639 ("firmware: smccc: Add ARCH_SOC_ID support") Good catch. Reviewed-by: Sudeep Holla Can you please re-post with my review tag keeping arm@kernel.org and soc@kernel.org ? I don't have any other fixes at the moment, we can ask SoC maintainers to fix this up directly. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel