From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04A98C433F5 for ; Mon, 22 Nov 2021 12:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wGhKM9w0kXltwfjortiBdl3nkRHIYGcI873gTkQ42qQ=; b=dgUC/P45xZKwm2 sNv532K2WCw6M4NPSzs8MjraEpofJmuR8fBhSw82iXI6bZrq69uYd6WIIOGNqEyDLqXK/y9sZU4p8 YkZMv8JUcQfeCQfJgxe7B8QC3DOV/JQehFiWaPHQGmlDdMSG9+a/Npe8IHvnDixIhgZjKy5xo5Ax6 Rllp9OyoSvt9doP17v4Xhm8V/mx435vDbdeiP1vvZvUG/7o5VfItA6o1RwZg0itp1h/sGxg/La5SB EiVo7k/WVn6ii9pJsGfy1IjIUuLBgdgwmW1bUszWVMJ0JGRIbKD85K/IoQ0L9lsZ0CIELUegcpiMM Ii9WUSVepvzbnG452yVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp8DL-00GHsH-Ui; Mon, 22 Nov 2021 12:14:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp7sV-00GAnI-KH for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 11:52:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B96D6D; Mon, 22 Nov 2021 03:52:54 -0800 (PST) Received: from bogus (unknown [10.57.46.248]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC9913F73B; Mon, 22 Nov 2021 03:52:52 -0800 (PST) Date: Mon, 22 Nov 2021 11:52:50 +0000 From: Sudeep Holla To: Arnd Bergmann Cc: Michael Kelley , Mark Rutland , Lorenzo Pieralisi , Steven Price , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH 1/1] firmware: smccc: Fix check for ARCH_SOC_ID not implemented Message-ID: <20211122115250.zlk4az3idtqhlm3z@bogus> References: <1637365141-16823-1-git-send-email-mikelley@microsoft.com> <20211122083503.umkqv2t75osypsbx@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_035255_752411_55AF4A26 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 22, 2021 at 11:56:16AM +0100, Arnd Bergmann wrote: > On Mon, Nov 22, 2021 at 9:35 AM Sudeep Holla wrote: > > On Fri, Nov 19, 2021 at 03:39:01PM -0800, Michael Kelley wrote: > > > The ARCH_FEATURES function ID is a 32-bit SMC call, which returns > > > a 32-bit result per the SMCCC spec. Current code is doing a 64-bit > > > comparison against -1 (SMCCC_RET_NOT_SUPPORTED) to detect that the > > > feature is unimplemented. That check doesn't work in a Hyper-V VM, > > > where the upper 32-bits are zero as allowed by the spec. > > > > > > Cast the result as an 'int' so the comparison works. The change also > > > makes the code consistent with other similar checks in this file. > > > > > > Fixes: 821b67fa4639 ("firmware: smccc: Add ARCH_SOC_ID support") > > > > Good catch. > > > > Reviewed-by: Sudeep Holla > > > > Can you please re-post with my review tag keeping arm@kernel.org and > > soc@kernel.org ? I don't have any other fixes at the moment, we can > > ask SoC maintainers to fix this up directly. > > In general, I think the easiest way would be for you to forward the > patch with your Signed-off-by, when you don't have other material > for a pull request. > Thanks for the tip, I will follow that in future. > I've applied this patch from the list now. > Thanks for that. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel