From: Maxime Ripard <maxime@cerno.tech>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function
Date: Mon, 22 Nov 2021 15:09:29 +0100 [thread overview]
Message-ID: <20211122140929.22cmvnxxapp752ic@gilmour> (raw)
In-Reply-To: <CAMty3ZAzwKtABZqJhVDmgOVpnZFg66z6Bc_pn3Fm9=658RPG1g@mail.gmail.com>
On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote:
> > It's perfectly valid to dereference the pointer in atomic_enable, and
> > that patch would consume memory for no particular reason.
>
> Again, I'm not pointing any mistake in dereference and certainly not
> understand about what memory consumption issue here.
You add a struct drm_display_mode field to struct sun6i_dsi. It
increases the size of struct sun6i_dsi of sizeof(struct
drm_display_mode).
> I'm doing it here since I'm doing it via mode_set in other drivers. No
> problem for me either way.
But *why* are you doing so?
There might be a valid reason in other drivers, but there's none here
(that you mentioned at least).
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-22 14:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 6:52 [PATCH v5 0/7] drm: sun4i: dsi: Convert drm bridge Jagan Teki
2021-11-22 6:52 ` [PATCH v5 1/7] drm: sun4i: dsi: Drop DRM bind race with bridge attach Jagan Teki
2021-11-22 6:52 ` [PATCH v5 2/7] drm: sun4i: dsi: Add component only once DSI device attached Jagan Teki
2021-11-22 6:52 ` [PATCH v5 3/7] drm: sun4i: dsi: Convert to bridge driver Jagan Teki
2021-11-22 10:07 ` Maxime Ripard
2021-11-22 12:45 ` Laurent Pinchart
2021-11-22 13:48 ` Jagan Teki
2021-11-22 14:04 ` Maxime Ripard
2021-11-22 14:19 ` Jagan Teki
2021-11-22 15:04 ` Maxime Ripard
2021-11-25 16:17 ` Jagan Teki
2021-11-23 18:32 ` Jagan Teki
2021-11-25 14:15 ` Maxime Ripard
2021-11-25 14:25 ` Jagan Teki
2021-11-25 16:10 ` Maxime Ripard
2021-11-25 16:14 ` Jagan Teki
2021-11-26 16:04 ` Maxime Ripard
2021-11-30 7:39 ` Jagan Teki
2021-12-05 17:39 ` Michael Nazzareno Trimarchi
2021-11-22 12:52 ` Neil Armstrong
2021-11-22 13:16 ` Jagan Teki
2021-11-22 15:35 ` Neil Armstrong
2021-11-22 17:19 ` Dave Stevenson
2021-11-23 8:19 ` Neil Armstrong
2021-11-22 6:52 ` [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function Jagan Teki
2021-11-22 10:07 ` Maxime Ripard
2021-11-22 13:05 ` Jagan Teki
2021-11-22 13:28 ` Maxime Ripard
2021-11-22 13:51 ` Jagan Teki
2021-11-22 14:09 ` Maxime Ripard [this message]
2021-11-22 14:31 ` Jagan Teki
2021-11-22 15:06 ` Maxime Ripard
2021-11-22 15:17 ` Jagan Teki
2021-11-22 6:52 ` [DO NOT MERGE] [PATCH v5 5/7] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 Panel Jagan Teki
2021-11-22 6:52 ` [DO NOT MERGE] [PATCH v5 6/7] ARM: dts: sun8i: bananapi-m2m: Enable ICN6211 DSI Bridge Jagan Teki
2021-11-22 6:52 ` [DO NOT MERGE] [PATCH v5 7/7] ARM: dts: sun8i: Enable DLPC3433 Bridge (I2C) Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122140929.22cmvnxxapp752ic@gilmour \
--to=maxime@cerno.tech \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).