From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBE51C433EF for ; Mon, 22 Nov 2021 18:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cDtvnlGnUcL8MLirMCFL8JQKGg5IbeGshD7f4SN/i30=; b=DKpl6QKmvMU++h 5CrIV+qKqSmsUFqwtkERUQ2Cd0T76LHj4uJ+Oef3OhqaqDo/0KB4xVPUzFFmpy2uMERIf/Lh1DdL0 Kqh6dDDEej4/GtRGrCu9opB26T3yxgJk+k/RgtMRwviYJjkjgfSklEq43XaBMdxiMQwjfOY7mSOAC lagLAO83QrHULblYw5RtqMt7AMxLpSy0wNkWEDNGdDMNDiKav2V+eYmGEIVnspV+MVvI/LjIqTy6B FgvoVP9VbWnxMM8FqiOm95eS4otaReBqVp+DFTqnPAIS10V1i9OsxHJHdxuC+r/MXnRkQFIrOFsKz sm7IEhnaBnWofGjT0x+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpDax-00HIAf-UB; Mon, 22 Nov 2021 17:59:12 +0000 Received: from soltyk.jannau.net ([144.76.91.90]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpDat-00HI85-QO for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 17:59:09 +0000 Received: by soltyk.jannau.net (Postfix, from userid 1000) id 3EDF5261B33; Mon, 22 Nov 2021 18:59:03 +0100 (CET) Date: Mon, 22 Nov 2021 18:59:03 +0100 From: Janne Grunau To: Sven Peter Cc: Hector Martin , Alyssa Rosenzweig , Rob Herring , Wolfram Sang , Olof Johansson , Arnd Bergmann , Mark Kettenis , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles Message-ID: <20211122175903.GA28130@jannau.net> References: <20211121171545.27402-1-j@jannau.net> <20211121171545.27402-3-j@jannau.net> <2baebbe6-0080-4cff-86de-a00f23aea95e@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2baebbe6-0080-4cff-86de-a00f23aea95e@www.fastmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_095908_058222_BFE01B24 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-11-21 21:22:47 +0100, Sven Peter wrote: > Hi, > > On Sun, Nov 21, 2021, at 18:15, Janne Grunau wrote: > > The intention was to have a SoC-specific and base compatible string > > to allow forward compatibility and SoC specific quirks, > > > > Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings") > > Signed-off-by: Janne Grunau > > Cc: Mark Kettenis > > --- > > Yeah, this should've been "apple,t8103-i2c", "apple,i2c" all along :/ > Given that we have no i2c nodes in the dts yet and that this binding was > only added for -rc1 I think it's fine to just drop "apple,t8103-i2c" > here instead of marking it as deprecated and keeping it around forever > if Mark Kettenis also agrees. > > > Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > > index 22fc8483256f..f1cb96c08212 100644 > > --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > > @@ -20,9 +20,10 @@ allOf: > > > > properties: > > compatible: > > - enum: > > - - apple,t8103-i2c > > - - apple,i2c > > + items: > > + - enum: > > + - apple,t8103-i2c > > + - const: apple,i2c > > Nit: the enum makes sense once we add t6000-i2c but right now > > properties: > compatible: > items: > - const: apple,t8103-i2c > - const: apple,i2c > > also works and look a bit less weird. I split it from change which in addition added "apple,t6000-i2c" as second enum value. I have no strong preference but the weirdness will hopefully vanish soon. Janne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel