From: Shawn Guo <shawnguo@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>,
Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Martin Kepplinger <martink@posteo.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node
Date: Tue, 23 Nov 2021 16:58:42 +0800 [thread overview]
Message-ID: <20211123085841.GX31998@dragon> (raw)
In-Reply-To: <1636629369-23988-1-git-send-email-abel.vesa@nxp.com>
On Thu, Nov 11, 2021 at 01:16:09PM +0200, Abel Vesa wrote:
> Adding interconnect properties to the consumer nodes creates
> a dependency on noc device. The imx-bus devfreq driver is not usable
> without the full interconnect support. The interconnect is not yet
> working on i.MX platforms. The devlink created on device_add makes
> the lcdif and other nodes that have the interconnect properties
> wait for the noc (imx-bus driver) to probe first.
>
> To make sure the interconnect consumers (nodes that have interconnect
> properties already added) will still probe, lets disable the noc node
> for now. Once the interconnect on i.MX platforms is fully functional,
> the status of the noc node can be changed.
>
> Fixes: ad1abc8a03fdbc05b ("arm64: dts: imx8mq: Add interconnect for lcdif")
Martin,
Do you have any comment? So your commit added something untested?
Shawn
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 972766b67a15..f3182878f596 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1305,6 +1305,7 @@ noc: interconnect@32700000 {
> fsl,ddrc = <&ddrc>;
> #interconnect-cells = <1>;
> operating-points-v2 = <&noc_opp_table>;
> + status = "disabled";
>
> noc_opp_table: opp-table {
> compatible = "operating-points-v2";
> --
> 2.31.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-23 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 11:16 [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node Abel Vesa
2021-11-23 8:58 ` Shawn Guo [this message]
2021-11-23 9:15 ` Martin Kepplinger
2021-11-23 9:24 ` Shawn Guo
2021-11-23 9:30 ` Martin Kepplinger
2021-11-23 11:07 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123085841.GX31998@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=martink@posteo.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).