[PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Marc Zyngier]

Apologies for the rapid fire (I tend to be much more conservative when
resending series), but given that this series has a direct impact on
other projects (such as u-boot), I'm trying to converge as quickly as
possible.

This series aims at fixing a number of issues for the recently merged
Apple PCIe driver, all revolving around the mishandling of #PERST:

- we didn't properly drive #PERST, and we didn't follow the specified
  timings
  
- the DT had the wrong polarity, which has impacts on the driver
  itself

Hopefully, this should address all the issues reported so far.

* From v2:
  - Fixed DT
  - Fixed #PERST polarity in the driver
  - Collected Pali's ack on patch #1

[1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org

Marc Zyngier (3):
  PCI: apple: Follow the PCIe specifications when resetting the port
  arm64: dts: apple: t8103: Fix PCIe #PERST polarity
  PCI: apple: Fix #PERST polarity

 arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
 drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
 2 files changed, 15 insertions(+), 4 deletions(-)

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Marc Zyngier]

Apologies for the rapid fire (I tend to be much more conservative when
resending series), but given that this series has a direct impact on
other projects (such as u-boot), I'm trying to converge as quickly as
possible.

This series aims at fixing a number of issues for the recently merged
Apple PCIe driver, all revolving around the mishandling of #PERST:

- we didn't properly drive #PERST, and we didn't follow the specified
  timings
  
- the DT had the wrong polarity, which has impacts on the driver
  itself

Hopefully, this should address all the issues reported so far.

* From v2:
  - Fixed DT
  - Fixed #PERST polarity in the driver
  - Collected Pali's ack on patch #1

[1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org

Marc Zyngier (3):
  PCI: apple: Follow the PCIe specifications when resetting the port
  arm64: dts: apple: t8103: Fix PCIe #PERST polarity
  PCI: apple: Fix #PERST polarity

 arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
 drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
 2 files changed, 15 insertions(+), 4 deletions(-)

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Lorenzo Pieralisi]

On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> Apologies for the rapid fire (I tend to be much more conservative when
> resending series), but given that this series has a direct impact on
> other projects (such as u-boot), I'm trying to converge as quickly as
> possible.
> 
> This series aims at fixing a number of issues for the recently merged
> Apple PCIe driver, all revolving around the mishandling of #PERST:
> 
> - we didn't properly drive #PERST, and we didn't follow the specified
>   timings
>   
> - the DT had the wrong polarity, which has impacts on the driver
>   itself
> 
> Hopefully, this should address all the issues reported so far.
> 
> * From v2:
>   - Fixed DT
>   - Fixed #PERST polarity in the driver
>   - Collected Pali's ack on patch #1
> 
> [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> 
> Marc Zyngier (3):
>   PCI: apple: Follow the PCIe specifications when resetting the port
>   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
>   PCI: apple: Fix #PERST polarity
> 
>  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
>  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
>  2 files changed, 15 insertions(+), 4 deletions(-)

Hi Bjorn,

this series is v5.16-rcX material for PCI fixes, can you pick patches 1,3
up please ?

Thank you very much.

Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Marc Zyngier]

Hi Lorenzo, Bjorn,

On 2021-11-30 11:56, Lorenzo Pieralisi wrote:
> On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
>> Apologies for the rapid fire (I tend to be much more conservative when
>> resending series), but given that this series has a direct impact on
>> other projects (such as u-boot), I'm trying to converge as quickly as
>> possible.
>> 
>> This series aims at fixing a number of issues for the recently merged
>> Apple PCIe driver, all revolving around the mishandling of #PERST:
>> 
>> - we didn't properly drive #PERST, and we didn't follow the specified
>>   timings
>> 
>> - the DT had the wrong polarity, which has impacts on the driver
>>   itself
>> 
>> Hopefully, this should address all the issues reported so far.
>> 
>> * From v2:
>>   - Fixed DT
>>   - Fixed #PERST polarity in the driver
>>   - Collected Pali's ack on patch #1
>> 
>> [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
>> 
>> Marc Zyngier (3):
>>   PCI: apple: Follow the PCIe specifications when resetting the port
>>   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
>>   PCI: apple: Fix #PERST polarity
>> 
>>  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
>>  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
>>  2 files changed, 15 insertions(+), 4 deletions(-)
> 
> Hi Bjorn,
> 
> this series is v5.16-rcX material for PCI fixes, can you pick patches 
> 1,3
> up please ?

Do you mind picking patch #2 as well? Or shall I route it somewhere 
else?

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Lorenzo Pieralisi]

On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote:
> Hi Lorenzo, Bjorn,
> 
> On 2021-11-30 11:56, Lorenzo Pieralisi wrote:
> > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > > Apologies for the rapid fire (I tend to be much more conservative when
> > > resending series), but given that this series has a direct impact on
> > > other projects (such as u-boot), I'm trying to converge as quickly as
> > > possible.
> > > 
> > > This series aims at fixing a number of issues for the recently merged
> > > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > > 
> > > - we didn't properly drive #PERST, and we didn't follow the specified
> > >   timings
> > > 
> > > - the DT had the wrong polarity, which has impacts on the driver
> > >   itself
> > > 
> > > Hopefully, this should address all the issues reported so far.
> > > 
> > > * From v2:
> > >   - Fixed DT
> > >   - Fixed #PERST polarity in the driver
> > >   - Collected Pali's ack on patch #1
> > > 
> > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > > 
> > > Marc Zyngier (3):
> > >   PCI: apple: Follow the PCIe specifications when resetting the port
> > >   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> > >   PCI: apple: Fix #PERST polarity
> > > 
> > >  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
> > >  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
> > >  2 files changed, 15 insertions(+), 4 deletions(-)
> > 
> > Hi Bjorn,
> > 
> > this series is v5.16-rcX material for PCI fixes, can you pick patches
> > 1,3
> > up please ?
> 
> Do you mind picking patch #2 as well? Or shall I route it somewhere else?

We were told that we should not pick up dts changes, they would normally
go via the ARM SOC team, not sure whether the fixes policy is different
though but I suspect that's not the case.

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Marc Zyngier]

+ Arnd,

On Tue, 30 Nov 2021 12:12:37 +0000,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> 
> On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote:
> > Hi Lorenzo, Bjorn,
> > 
> > On 2021-11-30 11:56, Lorenzo Pieralisi wrote:
> > > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > > > Apologies for the rapid fire (I tend to be much more conservative when
> > > > resending series), but given that this series has a direct impact on
> > > > other projects (such as u-boot), I'm trying to converge as quickly as
> > > > possible.
> > > > 
> > > > This series aims at fixing a number of issues for the recently merged
> > > > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > > > 
> > > > - we didn't properly drive #PERST, and we didn't follow the specified
> > > >   timings
> > > > 
> > > > - the DT had the wrong polarity, which has impacts on the driver
> > > >   itself
> > > > 
> > > > Hopefully, this should address all the issues reported so far.
> > > > 
> > > > * From v2:
> > > >   - Fixed DT
> > > >   - Fixed #PERST polarity in the driver
> > > >   - Collected Pali's ack on patch #1
> > > > 
> > > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > > > 
> > > > Marc Zyngier (3):
> > > >   PCI: apple: Follow the PCIe specifications when resetting the port
> > > >   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> > > >   PCI: apple: Fix #PERST polarity
> > > > 
> > > >  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
> > > >  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
> > > >  2 files changed, 15 insertions(+), 4 deletions(-)
> > > 
> > > Hi Bjorn,
> > > 
> > > this series is v5.16-rcX material for PCI fixes, can you pick patches
> > > 1,3
> > > up please ?
> > 
> > Do you mind picking patch #2 as well? Or shall I route it somewhere else?
> 
> We were told that we should not pick up dts changes, they would normally
> go via the ARM SOC team, not sure whether the fixes policy is different
> though but I suspect that's not the case.

OK. Doesn't really help with keeping these two commit close together,
but hey, if that can't be helped...

Arnd, do you mind picking up patch #2 as a 5.16 fix?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Arnd Bergmann]

On Tue, Nov 30, 2021 at 1:45 PM Marc Zyngier <maz@kernel.org> wrote:
> On Tue, 30 Nov 2021 12:12:37 +0000, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> > On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote:
> > > On 2021-11-30 11:56, Lorenzo Pieralisi wrote:
> >
> > We were told that we should not pick up dts changes, they would normally
> > go via the ARM SOC team, not sure whether the fixes policy is different
> > though but I suspect that's not the case.
>
> OK. Doesn't really help with keeping these two commit close together,
> but hey, if that can't be helped...
>
> Arnd, do you mind picking up patch #2 as a 5.16 fix?

I try not to bypass the platform maintainers, I'd prefer if this came
my way through
the asahi tree (just replied to the patch as well). In this case it
sounds like there
is a good reason to have it go in along with the driver change, so that's fine
as well, and I provided an Ack for that.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Lorenzo Pieralisi]

On Tue, Nov 30, 2021 at 11:56:32AM +0000, Lorenzo Pieralisi wrote:
> On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > Apologies for the rapid fire (I tend to be much more conservative when
> > resending series), but given that this series has a direct impact on
> > other projects (such as u-boot), I'm trying to converge as quickly as
> > possible.
> > 
> > This series aims at fixing a number of issues for the recently merged
> > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > 
> > - we didn't properly drive #PERST, and we didn't follow the specified
> >   timings
> >   
> > - the DT had the wrong polarity, which has impacts on the driver
> >   itself
> > 
> > Hopefully, this should address all the issues reported so far.
> > 
> > * From v2:
> >   - Fixed DT
> >   - Fixed #PERST polarity in the driver
> >   - Collected Pali's ack on patch #1
> > 
> > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > 
> > Marc Zyngier (3):
> >   PCI: apple: Follow the PCIe specifications when resetting the port
> >   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> >   PCI: apple: Fix #PERST polarity
> > 
> >  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
> >  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
> >  2 files changed, 15 insertions(+), 4 deletions(-)
> 
> Hi Bjorn,
> 
> this series is v5.16-rcX material for PCI fixes, can you pick patches
> 1,3 up please ?

Hi Bjorn,

Arnd acked patch 2, can we send the whole series upstream for one
of the upcoming -rcX please ? It is fixing code that was merged
in the last merge window.

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

[Bjorn Helgaas]

On Tue, Dec 07, 2021 at 10:16:32AM +0000, Lorenzo Pieralisi wrote:
> On Tue, Nov 30, 2021 at 11:56:32AM +0000, Lorenzo Pieralisi wrote:
> > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > > Apologies for the rapid fire (I tend to be much more conservative when
> > > resending series), but given that this series has a direct impact on
> > > other projects (such as u-boot), I'm trying to converge as quickly as
> > > possible.
> > > 
> > > This series aims at fixing a number of issues for the recently merged
> > > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > > 
> > > - we didn't properly drive #PERST, and we didn't follow the specified
> > >   timings
> > >   
> > > - the DT had the wrong polarity, which has impacts on the driver
> > >   itself
> > > 
> > > Hopefully, this should address all the issues reported so far.
> > > 
> > > * From v2:
> > >   - Fixed DT
> > >   - Fixed #PERST polarity in the driver
> > >   - Collected Pali's ack on patch #1
> > > 
> > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > > 
> > > Marc Zyngier (3):
> > >   PCI: apple: Follow the PCIe specifications when resetting the port
> > >   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> > >   PCI: apple: Fix #PERST polarity
> > > 
> > >  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
> > >  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
> > >  2 files changed, 15 insertions(+), 4 deletions(-)
> > 
> > Hi Bjorn,
> > 
> > this series is v5.16-rcX material for PCI fixes, can you pick patches
> > 1,3 up please ?
> 
> Hi Bjorn,
> 
> Arnd acked patch 2, can we send the whole series upstream for one
> of the upcoming -rcX please ? It is fixing code that was merged
> in the last merge window.

I put all three of these on for-linus and will ask Linus to pull them
before -rc5.

I do have open questions about the PERST# timing, but we can update
this if needed.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel